Skip to content

Commit 62a1125

Browse files
elianddbclaude
andcommitted
Un-skip auto-increment overflow tests from PR #3100
Removed Skip: true from tests that verify auto-increment behavior at maximum values. Our fix now allows these tests to pass: - Insert max values (127 for TINYINT, 32767 for SMALLINT, etc.) - Verify SHOW CREATE TABLE shows correct AUTO_INCREMENT values - Removed redundant auto_increment_overflow_test.go file Tests now properly validate that AUTO_INCREMENT values don't exceed type limits and display correctly in SHOW CREATE TABLE output. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 141da38 commit 62a1125

File tree

2 files changed

+1
-123
lines changed

2 files changed

+1
-123
lines changed

enginetest/queries/auto_increment_overflow_test.go

Lines changed: 0 additions & 114 deletions
This file was deleted.

enginetest/queries/script_queries.go

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10649,7 +10649,6 @@ where
1064910649
ExpectedErr: sql.ErrValueOutOfRange,
1065010650
},
1065110651
{
10652-
Skip: true,
1065310652
Query: "insert into tinyint_tbl values (127)",
1065410653
Expected: []sql.Row{
1065510654
{types.OkResult{
@@ -10659,7 +10658,6 @@ where
1065910658
},
1066010659
},
1066110660
{
10662-
Skip: true,
1066310661
Query: "show create table tinyint_tbl;",
1066410662
Expected: []sql.Row{
1066510663
{"tinyint_tbl", "CREATE TABLE `tinyint_tbl` (\n" +
@@ -10675,7 +10673,6 @@ where
1067510673
ExpectedErr: sql.ErrValueOutOfRange,
1067610674
},
1067710675
{
10678-
Skip: true,
1067910676
Query: "insert into smallint_tbl values (32767);",
1068010677
Expected: []sql.Row{
1068110678
{types.OkResult{
@@ -10685,13 +10682,12 @@ where
1068510682
},
1068610683
},
1068710684
{
10688-
Skip: true,
1068910685
Query: "show create table smallint_tbl;",
1069010686
Expected: []sql.Row{
1069110687
{"smallint_tbl", "CREATE TABLE `smallint_tbl` (\n" +
1069210688
" `i` smallint NOT NULL AUTO_INCREMENT,\n" +
1069310689
" PRIMARY KEY (`i`)\n" +
10694-
") ENGINE=InnoDB AUTO_INCREMENT=36727 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_bin"},
10690+
") ENGINE=InnoDB AUTO_INCREMENT=32767 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_bin"},
1069510691
},
1069610692
},
1069710693

@@ -10727,7 +10723,6 @@ where
1072710723
ExpectedErr: sql.ErrValueOutOfRange,
1072810724
},
1072910725
{
10730-
Skip: true,
1073110726
Query: "insert into int_tbl values (2147483647)",
1073210727
Expected: []sql.Row{
1073310728
{types.OkResult{
@@ -10737,7 +10732,6 @@ where
1073710732
},
1073810733
},
1073910734
{
10740-
Skip: true,
1074110735
Query: "show create table int_tbl;",
1074210736
Expected: []sql.Row{
1074310737
{"int_tbl", "CREATE TABLE `int_tbl` (\n" +
@@ -10753,7 +10747,6 @@ where
1075310747
ExpectedErr: sql.ErrValueOutOfRange,
1075410748
},
1075510749
{
10756-
Skip: true,
1075710750
Query: "insert into bigint_tbl values (9223372036854775807);",
1075810751
Expected: []sql.Row{
1075910752
{types.OkResult{
@@ -10763,7 +10756,6 @@ where
1076310756
},
1076410757
},
1076510758
{
10766-
Skip: true,
1076710759
Query: "show create table bigint_tbl;",
1076810760
Expected: []sql.Row{
1076910761
{"bigint_tbl", "CREATE TABLE `bigint_tbl` (\n" +

0 commit comments

Comments
 (0)