Skip to content

Commit 63c9c0f

Browse files
committed
comment out test
1 parent cc20881 commit 63c9c0f

File tree

1 file changed

+17
-18
lines changed

1 file changed

+17
-18
lines changed

sql/expression/function/aggregation/window_partition_test.go

Lines changed: 17 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import (
2323

2424
"github.com/dolthub/go-mysql-server/memory"
2525
"github.com/dolthub/go-mysql-server/sql"
26-
"github.com/dolthub/go-mysql-server/sql/expression"
2726
"github.com/dolthub/go-mysql-server/sql/types"
2827
)
2928

@@ -233,23 +232,23 @@ func TestWindowPartition_MaterializeOutput(t *testing.T) {
233232
require.ElementsMatch(t, nil, output)
234233
})
235234

236-
t.Skip("nil input no partition by", func(t *testing.T) {
237-
ctx := sql.NewEmptyContext()
238-
i := NewWindowPartitionIter(
239-
&WindowPartition{
240-
PartitionBy: nil,
241-
Aggs: []*Aggregation{
242-
NewAggregation(NewCountAgg(expression.NewGetField(0, types.Int64, "z", true)), NewGroupByFramer()),
243-
},
244-
})
245-
i.input = []sql.Row{}
246-
i.partitions = []sql.WindowInterval{{0, 0}}
247-
i.outputOrdering = nil
248-
output, err := i.materializeOutput(ctx)
249-
require.NoError(t, err)
250-
expOutput := []sql.Row{{int64(0), nil}}
251-
require.ElementsMatch(t, expOutput, output)
252-
})
235+
//t.Run("nil input no partition by", func(t *testing.T) {
236+
// ctx := sql.NewEmptyContext()
237+
// i := NewWindowPartitionIter(
238+
// &WindowPartition{
239+
// PartitionBy: nil,
240+
// Aggs: []*Aggregation{
241+
// NewAggregation(NewCountAgg(expression.NewGetField(0, types.Int64, "z", true)), NewGroupByFramer()),
242+
// },
243+
// })
244+
// i.input = []sql.Row{}
245+
// i.partitions = []sql.WindowInterval{{0, 0}}
246+
// i.outputOrdering = nil
247+
// output, err := i.materializeOutput(ctx)
248+
// require.NoError(t, err)
249+
// expOutput := []sql.Row{{int64(0), nil}}
250+
// require.ElementsMatch(t, expOutput, output)
251+
//})
253252
}
254253

255254
func TestWindowPartition_SortAndFilterOutput(t *testing.T) {

0 commit comments

Comments
 (0)