clean up and comments

Author: James Cor

sql/analyzer/fix_exec_indexes.go

@@ -583,7 +583,9 @@ func (s *idxScope) visitSelf(n sql.Node) error {
 			// default nodes can't see lateral join nodes, unless we're in lateral
 			// join and lateral scopes are promoted to parent status
 			for _, e := range ne.Expressions() {
-				// groupConcat is special as it appends results to outer scope row.
+				// groupConcat is special as it appends results to outer scope row
+				// we need to account for this extra column in the rows when assigning indexes
+				// see gms/expression/function/aggregation/group_concat.go:groupConcatBuffer.Update()
 				if gc, isGc := e.(*aggregation.GroupConcat); isGc {
 					selExprs := gc.GetSelectExprs()
 					selScope := &idxScope{}
@@ -748,10 +750,6 @@ func fixExprToScope(e sql.Expression, scopes ...*idxScope) sql.Expression {
 			//  this error for the case of DEFAULT in a `plan.Values`, since we analyze the insert source in isolation (we
 			//  don't have the destination schema, and column references in default values are determined in the build phase)
 
-			if e.Name() == "sum(t2.age)" {
-				print()
-			}
-
 			idx, _ := newScope.getIdxId(e.Id(), e.String())
 			if idx >= 0 {
 				return e.WithIndex(idx), transform.NewTree, nil

sql/expression/function/aggregation/group_concat.go

@@ -297,7 +297,6 @@ func (g *groupConcatBuffer) Update(ctx *sql.Context, originalRow sql.Row) error
 
 	// Append the current value to the end of the row. We want to preserve the row's original structure for
 	// for sort ordering in the final step.
-	// TODO: why nil spacer?
 	g.rows = append(g.rows, append(originalRow, vs))
 
 	return nil