Skip to content

Commit 66798a4

Browse files
committed
test clean up
1 parent 16d9260 commit 66798a4

File tree

2 files changed

+15
-4
lines changed

2 files changed

+15
-4
lines changed

enginetest/queries/logic_test_scripts.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1005,6 +1005,7 @@ var SQLLogicSubqueryTests = []ScriptTest{
10051005
},
10061006
},
10071007
{
1008+
// Skipping because we don't convert Time objects to strings in enginetests
10081009
Skip: true,
10091010
Name: "multiple nested subquery",
10101011
SetUpScript: []string{

enginetest/queries/queries.go

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -828,10 +828,6 @@ var QueryTests = []QueryTest{
828828
Query: "select y as x from xy group by (y) having AVG(x) > 0",
829829
Expected: []sql.Row{{0}, {1}, {3}},
830830
},
831-
// {
832-
// Query: "select y as z from xy group by (y) having AVG(z) > 0",
833-
// Expected: []sql.Row{{1}, {2}, {3}},
834-
// },
835831
{
836832
Query: "SELECT * FROM mytable t0 INNER JOIN mytable t1 ON (t1.i IN (((true)%(''))));",
837833
Expected: []sql.Row{},
@@ -10654,6 +10650,20 @@ FROM mytable;`,
1065410650
{"DECIMAL"},
1065510651
},
1065610652
},
10653+
// https://github.com/dolthub/dolt/issues/7095
10654+
// References in group by and having should be allowed to match select aliases
10655+
{
10656+
Query: "select y as z from xy group by (y) having AVG(z) > 0",
10657+
Expected: []sql.Row{{1}, {2}, {3}},
10658+
},
10659+
{
10660+
Query: "select y as z from xy group by (z) having AVG(z) > 0",
10661+
Expected: []sql.Row{{1}, {2}, {3}},
10662+
},
10663+
{
10664+
Query: "select y + 1 as z from xy group by (z) having AVG(z) > 1",
10665+
Expected: []sql.Row{{2}, {3}, {4}},
10666+
},
1065710667
}
1065810668

1065910669
var VersionedQueries = []QueryTest{

0 commit comments

Comments
 (0)