Skip to content

Commit 6edcc34

Browse files
committed
add issue link to join op test
1 parent 513621f commit 6edcc34

File tree

2 files changed

+98
-13
lines changed

2 files changed

+98
-13
lines changed

enginetest/join_op_tests.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2064,6 +2064,7 @@ WHERE
20642064
},
20652065
},
20662066
{
2067+
// https://github.com/dolthub/dolt/issues/9777
20672068
name: "join with % condition",
20682069
setup: [][]string{
20692070
{

enginetest/memory_engine_test.go

Lines changed: 97 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -200,38 +200,122 @@ func TestSingleQueryPrepared(t *testing.T) {
200200

201201
// Convenience test for debugging a single query. Unskip and set to the desired query.
202202
func TestSingleScript(t *testing.T) {
203-
t.Skip()
203+
// t.Skip()
204204
var scripts = []queries.ScriptTest{
205205
{
206-
Name: "AS OF propagates to nested CALLs",
207-
SetUpScript: []string{},
206+
Name: "join on empty",
207+
SetUpScript: []string{
208+
"create table t(c int)",
209+
"insert into t values (1)",
210+
},
208211
Assertions: []queries.ScriptTestAssertion{
209212
{
210-
Query: "create procedure create_proc() create table t (i int primary key, j int);",
211-
Expected: []sql.Row{
212-
{types.NewOkResult(0)},
213-
},
213+
Query: "select t.c from t left join (select t2.c from t as t2 where false) as subq on true",
214+
Expected: []sql.Row{{1}},
214215
},
215216
{
216-
Query: "call create_proc()",
217+
Query: "select t.c from t natural left join (select t2.c from t as t2 where false) as subq",
218+
Expected: []sql.Row{{1}},
219+
},
220+
{
221+
Query: "select t.c from (select t.c from t where false) as subq right join t on true",
222+
Expected: []sql.Row{{1}},
223+
},
224+
{
225+
Query: "select t.c from (select t.c from t where false) as subq natural right join t",
226+
Expected: []sql.Row{{1}},
227+
},
228+
},
229+
},
230+
{
231+
Skip: true,
232+
Assertions: []queries.ScriptTestAssertion{
233+
{
234+
// test cross join used as projected subquery expression
235+
Query: "select 1 as exprAlias, 2, 3, (select exprAlias + count(*) from one_pk_three_idx a cross join one_pk_three_idx b);",
236+
Expected: []sql.Row{{1, 2, 3, 65}},
237+
},
238+
{
239+
Query: "SELECT count(*), (SELECT i FROM mytable WHERE i = 1 group by i);",
217240
Expected: []sql.Row{
218-
{types.NewOkResult(0)},
241+
{1, 1},
219242
},
220243
},
221244
},
222245
},
246+
{
247+
Skip: true,
248+
Name: "strings cast to numbers in log",
249+
SetUpScript: []string{},
250+
Assertions: []queries.ScriptTestAssertion{
251+
{
252+
Query: "select (11 + '11asdf')",
253+
Expected: []sql.Row{{float64(22)}},
254+
},
255+
{
256+
Skip: true,
257+
Query: "select log('10asdf', '100f')",
258+
Expected: []sql.Row{{float64(2)}},
259+
},
260+
{
261+
Skip: true,
262+
Query: "select log('a10asdf', 'b100f')",
263+
Expected: []sql.Row{{nil}},
264+
},
265+
},
266+
},
267+
{
268+
Skip: true,
269+
Name: "strings cast to numbers",
270+
SetUpScript: []string{
271+
//"create table test01(pk varchar(20) primary key)",
272+
"create table test01(pk varchar(30))",
273+
`insert into test01 values (' 3 12 4'),
274+
(' 3.2 12 4'),('-3.1234'),('-3.1a'),('-5+8'),('+3.1234'),
275+
('11d'),('11wha?'),('11'),('12'),('1a1'),('a1a1'),('11-5'),
276+
('3. 12 4'),('5.932887e+07'),('5.932887e+07abc'),('5.932887e7'),('5.932887e7abc')`,
277+
},
278+
Assertions: []queries.ScriptTestAssertion{
279+
{
280+
Skip: true,
281+
Query: "select pk from test01 where pk=11 order by pk",
282+
Expected: []sql.Row{{"11"}, {"11-5"}, {"11d"}, {"11wha?"}},
283+
},
284+
{
285+
Query: "select pk from test01 where pk in (11) order by pk",
286+
Expected: []sql.Row{{"11"}, {"11-5"}, {"11d"}, {"11wha?"}},
287+
},
288+
{
289+
Skip: true,
290+
Query: "select pk from test01 where pk in ('11')",
291+
Expected: []sql.Row{{"11"}},
292+
},
293+
{
294+
Skip: true,
295+
Query: "select log('10asdf', '100f')",
296+
Expected: []sql.Row{{float64(2)}},
297+
},
298+
{
299+
Skip: true,
300+
Query: "select log('a10asdf', 'b100f')",
301+
Expected: []sql.Row{{nil}},
302+
},
303+
},
304+
},
223305
}
224306

225307
for _, test := range scripts {
226308
harness := enginetest.NewMemoryHarness("", 1, testNumPartitions, true, nil)
227-
//harness.UseServer()
309+
harness.Setup(setup.SimpleSetup...)
310+
// harness.UseServer()
228311
engine, err := harness.NewEngine(t)
312+
// engine.EngineAnalyzer().Coster = memo.NewLookupBiasedCoster()
229313
if err != nil {
230314
panic(err)
231315
}
232316

233-
//engine.EngineAnalyzer().Debug = true
234-
//engine.EngineAnalyzer().Verbose = true
317+
engine.EngineAnalyzer().Debug = true
318+
engine.EngineAnalyzer().Verbose = true
235319

236320
enginetest.TestScriptWithEngine(t, engine, harness, test)
237321
}
@@ -998,7 +1082,7 @@ func TestDatabaseCollationWire(t *testing.T) {
9981082

9991083
func TestTypesOverWire(t *testing.T) {
10001084
if _, ok := os.LookupEnv("CI_TEST"); !ok {
1001-
t.Skip("Skipping test that requires CI_TEST=true")
1085+
// t.Skip("Skipping test that requires CI_TEST=true")
10021086
}
10031087
harness := enginetest.NewDefaultMemoryHarness()
10041088
enginetest.TestTypesOverWire(t, harness, harness.SessionBuilder())

0 commit comments

Comments
 (0)