drop sorts in cross joins

James Cor · James Cor · commit 78124db55507 · 2025-07-24T12:55:15.000-07:00
diff --git a/sql/analyzer/replace_sort.go b/sql/analyzer/replace_sort.go
@@ -156,7 +156,7 @@ func replaceIdxSortHelper(ctx *sql.Context, scope *plan.Scope, node sql.Node, so
 		case *plan.JoinNode:
 			// TODO: is this applicable to other types of joins?
 			//   as long as left child is already sorted and SortFields are a prefix, then it's ok?
-			if !c.JoinType().IsMerge() {
+			if !c.JoinType().IsMerge() && !c.JoinType().IsCross() {
 				continue
 			}
 			// It's (probably) not possible to have Sort as child of Join without Subquery/SubqueryAlias,

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ func replaceIdxSortHelper(ctx sql.Context, scope plan.Scope, node sql.Node, so`
`156`	`156`	`case *plan.JoinNode:`
`157`	`157`	`// TODO: is this applicable to other types of joins?`
`158`	`158`	`// as long as left child is already sorted and SortFields are a prefix, then it's ok?`
`159`		`- if !c.JoinType().IsMerge() {`
	`159`	`+ if !c.JoinType().IsMerge() && !c.JoinType().IsCross() {`
`160`	`160`	`continue`
`161`	`161`	`}`
`162`	`162`	`// It's (probably) not possible to have Sort as child of Join without Subquery/SubqueryAlias,`