fix?

Author: James Cor

sql/base_session.go

@@ -255,12 +255,13 @@ func (s *BaseSession) IncrementStatusVariable(ctx *Context, statVarName string,
 }
 
 // NewStoredProcParam creates a new Stored Procedure Parameter in the Session
-func (s *BaseSession) NewStoredProcParam(name string, param *StoredProcParam) {
+func (s *BaseSession) NewStoredProcParam(name string, param *StoredProcParam) *StoredProcParam {
 	name = strings.ToLower(name)
-	if _, ok := s.storedProcParams[name]; ok {
-		return
+	if spp, ok := s.storedProcParams[name]; ok {
+		return spp
 	}
 	s.storedProcParams[name] = param
+	return param
 }
 
 // GetStoredProcParam retrieves the named stored procedure parameter, from the Session, returning nil if not found.

sql/planbuilder/proc.go

@@ -350,8 +350,8 @@ func (b *Builder) buildCall(inScope *scope, c *ast.Call) (outScope *scope) {
 		// catch this discrepancy.
 		if len(proc.Params) == len(c.Params) {
 			procParam := proc.Params[i]
-			rspp := &sql.StoredProcParam{Type: procParam.Type}
-			b.ctx.Session.NewStoredProcParam(procParam.Name, rspp)
+			rSpp := &sql.StoredProcParam{Type: procParam.Type}
+			rSpp = b.ctx.Session.NewStoredProcParam(procParam.Name, rSpp)
 			if col, isCol := param.(*ast.ColName); isCol {
 				colName := col.Name.String()
 				if spp := b.ctx.Session.GetStoredProcParam(colName); spp != nil {
@@ -360,7 +360,7 @@ func (b *Builder) buildCall(inScope *scope, c *ast.Call) (outScope *scope) {
 						Value: spp.Value,
 					}
 					param = iv.ToAST()
-					rspp.Reference = spp
+					rSpp.Reference = spp
 				}
 			}
 		}

sql/procedures/interpreter_logic.go

@@ -740,7 +740,7 @@ func execOp(ctx *sql.Context, runner sql.StatementRunner, stack *InterpreterStac
 				Type:  iv.Type,
 				Value: iv.Value,
 			}
-			ctx.Session.NewStoredProcParam(paramName, spp)
+			spp = ctx.Session.NewStoredProcParam(paramName, spp)
 			stackToParam[iv] = spp
 		}
 		sch, rowIter, err := query(ctx, runner, callStmt)

sql/session.go

@@ -93,7 +93,7 @@ type Session interface {
 	// IncrementStatusVariable increments the value of the status variable by the integer value
 	IncrementStatusVariable(ctx *Context, statVarName string, val int)
 	// NewStoredProcParam creates a new Stored Procedure Parameter in the Session.
-	NewStoredProcParam(name string, param *StoredProcParam)
+	NewStoredProcParam(name string, param *StoredProcParam) *StoredProcParam
 	// GetStoredProcParam finds and returns the Stored Procedure Parameter by the given name.
 	GetStoredProcParam(name string) *StoredProcParam
 	// SetStoredProcParam sets the Stored Procedure Parameter of the given name to the given val.