Skip to content

Commit 7a4d0e6

Browse files
macneale4claude
andcommitted
Update stored procedure tests to expect OkResult for SET statements
- Fixed TestStoredProcedures failures caused by SET statement behavior change - Updated procedure_queries.go test expectations from empty rows {} to types.NewOkResult(0) - SET statements in stored procedures now correctly return OkResult instead of empty rows - All stored procedure tests now pass with the new SET statement behavior This follows the fix for issue #13169 where SET statements were changed to return OkResult instead of empty rows to match MySQL behavior. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 54f35df commit 7a4d0e6

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

enginetest/queries/procedure_queries.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -325,20 +325,20 @@ END`,
325325
// need to filter out Result Sets that should be completely omitted.
326326
{
327327
Query: "CALL p1(0)",
328-
Expected: []sql.Row{{}},
328+
Expected: []sql.Row{{types.NewOkResult(0)}},
329329
},
330330
{
331331
Query: "CALL p1(1)",
332-
Expected: []sql.Row{{}},
332+
Expected: []sql.Row{{types.NewOkResult(0)}},
333333
},
334334
{
335335
Query: "CALL p1(2)",
336-
Expected: []sql.Row{{}},
336+
Expected: []sql.Row{{types.NewOkResult(0)}},
337337
},
338338
{
339339
// https://github.com/dolthub/dolt/issues/6230
340340
Query: "CALL p1(200)",
341-
Expected: []sql.Row{{}},
341+
Expected: []sql.Row{{types.NewOkResult(0)}},
342342
},
343343
},
344344
},
@@ -359,15 +359,15 @@ END`,
359359
// need to filter out Result Sets that should be completely omitted.
360360
{
361361
Query: "CALL p1(0)",
362-
Expected: []sql.Row{{}},
362+
Expected: []sql.Row{{types.NewOkResult(0)}},
363363
},
364364
{
365365
Query: "CALL p1(1)",
366-
Expected: []sql.Row{{}},
366+
Expected: []sql.Row{{types.NewOkResult(0)}},
367367
},
368368
{
369369
Query: "CALL p1(2)",
370-
Expected: []sql.Row{{}},
370+
Expected: []sql.Row{{types.NewOkResult(0)}},
371371
},
372372
},
373373
},
@@ -985,7 +985,7 @@ END;`,
985985
Assertions: []ScriptTestAssertion{
986986
{
987987
Query: "SET @x = 2;",
988-
Expected: []sql.Row{{}},
988+
Expected: []sql.Row{{types.NewOkResult(0)}},
989989
},
990990
{
991991
// TODO: Set statements don't return anything for whatever reason
@@ -2270,7 +2270,7 @@ end;
22702270
Assertions: []ScriptTestAssertion{
22712271
{
22722272
Query: "call proc();",
2273-
Expected: []sql.Row{{}},
2273+
Expected: []sql.Row{{types.NewOkResult(0)}},
22742274
},
22752275
{
22762276
Query: "select @v;",

0 commit comments

Comments
 (0)