made validation slightly faster

angelamayxie · angelamayxie · commit 7aa7aab98cdc · 2025-07-25T10:44:04.000-07:00
diff --git a/sql/time.go b/sql/time.go
@@ -49,11 +49,11 @@ func ConvertTimeZone(datetime time.Time, fromLocation string, toLocation string)
 }
 
 func ValidTimeZone(str string) bool {
-	_, err := time.LoadLocation(str)
-	if err == nil {
+	if strings.ToUpper(str) == "SYSTEM" || offsetRegex.MatchString(str) {
 		return true
 	}
-	return offsetRegex.MatchString(str) || strings.ToUpper(str) == "SYSTEM"
+	_, err := time.LoadLocation(str)
+	return err == nil
 }
 
 // MySQLOffsetToDuration takes in a MySQL timezone offset (e.g. "+01:00") and returns it as a time.Duration.

Original file line number	Diff line number	Diff line change
`@@ -49,11 +49,11 @@ func ConvertTimeZone(datetime time.Time, fromLocation string, toLocation string)`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`func ValidTimeZone(str string) bool {`
`52`		`- _, err := time.LoadLocation(str)`
`53`		`- if err == nil {`
	`52`	`+ if strings.ToUpper(str) == "SYSTEM" \|\| offsetRegex.MatchString(str) {`
`54`	`53`	`return true`
`55`	`54`	`}`
`56`		`- return offsetRegex.MatchString(str) \|\| strings.ToUpper(str) == "SYSTEM"`
	`55`	`+ _, err := time.LoadLocation(str)`
	`56`	`+ return err == nil`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`// MySQLOffsetToDuration takes in a MySQL timezone offset (e.g. "+01:00") and returns it as a time.Duration.`