Merge pull request #2940 from dolthub/fulghum/if_exists

fulghum · web-flow · commit 814abccc8b6d · 2025-04-14T16:34:48.000-07:00
Bug fix: ensure `DropCheck.IfExists` gets copied over to new instances
diff --git a/sql/plan/alter_check.go b/sql/plan/alter_check.go
@@ -128,7 +128,10 @@ func (d *DropCheck) WithChildren(children ...sql.Node) (sql.Node, error) {
 	if len(children) != 1 {
 		return nil, sql.ErrInvalidChildrenNumber.New(d, len(children), 1)
 	}
-	return NewAlterDropCheck(children[0].(*ResolvedTable), d.Name), nil
+
+	newAlterDropCheck := NewAlterDropCheck(children[0].(*ResolvedTable), d.Name)
+	newAlterDropCheck.IfExists = d.IfExists
+	return newAlterDropCheck, nil
 }
 
 // CollationCoercibility implements the interface sql.CollationCoercible.

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,10 @@ func (d *DropCheck) WithChildren(children ...sql.Node) (sql.Node, error) {`
`128`	`128`	`if len(children) != 1 {`
`129`	`129`	`return nil, sql.ErrInvalidChildrenNumber.New(d, len(children), 1)`
`130`	`130`	`}`
`131`		`- return NewAlterDropCheck(children[0].(*ResolvedTable), d.Name), nil`
	`131`	`+`
	`132`	`+ newAlterDropCheck := NewAlterDropCheck(children[0].(*ResolvedTable), d.Name)`
	`133`	`+ newAlterDropCheck.IfExists = d.IfExists`
	`134`	`+ return newAlterDropCheck, nil`
`132`	`135`	`}`
`133`	`136`
`134`	`137`	`// CollationCoercibility implements the interface sql.CollationCoercible.`