Skip to content

Commit 81d0c63

Browse files
author
James Cor
committed
update TODOs
1 parent 2cd246b commit 81d0c63

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

sql/analyzer/load_triggers.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ func loadTriggers(ctx *sql.Context, a *Analyzer, n sql.Node, scope *plan.Scope,
4444
}
4545
return &newShowTriggers, transform.NewTree, nil
4646
case *plan.DropTrigger:
47-
// TODO: load triggers without parsing
4847
loadedTriggers, err := loadTriggersFromDb(ctx, a, node.Database(), true)
4948
if err != nil {
5049
return nil, transform.SameTree, err
@@ -113,7 +112,8 @@ func loadTriggersFromDb(ctx *sql.Context, a *Analyzer, db sql.Database, ignorePa
113112
if !ignoreParseErrors {
114113
return nil, err
115114
}
116-
// TODO: we won't have TriggerOrder information for this unparseable trigger.
115+
// TODO: we won't have TriggerOrder information for this unparseable trigger,
116+
// but it will still be referenced by any valid triggers.
117117
fakeTrigger := &plan.CreateTrigger{
118118
TriggerName: trigger.Name,
119119
}

0 commit comments

Comments
 (0)