convert to bool rounds

Author: James Cor

enginetest/queries/script_queries.go

@@ -970,8 +970,8 @@ var ScriptTests = []ScriptTest{
 			},
 
 			// TODO: these are not directly testing casting
+			// https://github.com/dolthub/dolt/issues/9739
 			{
-				// https://github.com/dolthub/dolt/issues/9739
 				Skip:    true,
 				Dialect: "mysql",
 				Query:   "select * from test01 where pk in (11)",
@@ -1013,17 +1013,13 @@ var ScriptTests = []ScriptTest{
 				ExpectedWarning:       mysql.ERTruncatedWrongValue,
 			},
 			{
-				// https://github.com/dolthub/dolt/issues/9739
-				//Skip:                  true,
 				Dialect:               "mysql",
 				Query:                 "select * from test02 where pk in ('11asdf');",
 				Expected:              []sql.Row{{11}},
 				ExpectedWarningsCount: 1,
 				ExpectedWarning:       mysql.ERTruncatedWrongValue,
 			},
 			{
-				// https://github.com/dolthub/dolt/issues/9739
-				//Skip:                  true,
 				Dialect:               "mysql",
 				Query:                 "select * from test02 where pk='11.12asdf';",
 				Expected:              []sql.Row{},

sql/core.go

@@ -317,7 +317,7 @@ func ConvertToBool(ctx *Context, v interface{}) (bool, error) {
 	case float64:
 		return b != 0, nil
 	case string:
-		truncStr, didTrunc := TruncateStringToInt(b)
+		truncStr, didTrunc := TruncateStringToDouble(b)
 		if didTrunc {
 			ctx.Warn(mysql.ERTruncatedWrongValue, "%s", ErrTruncatedIncorrect.New("INTEGER", b))
 		}