fix int32 convert

Author: max-hoffman

sql/types/decimal.go

@@ -312,9 +312,7 @@ func (t DecimalType_) SQL(ctx *sql.Context, dest []byte, v interface{}) (sqltype
 	if err != nil {
 		return sqltypes.Value{}, err
 	}
-
 	val := encodings.StringToBytes(t.DecimalValueStringFixed(value.Decimal))
-
 	return sqltypes.MakeTrusted(sqltypes.Decimal, val), nil
 }
 

sql/types/number.go

@@ -453,10 +453,10 @@ func (t NumberTypeImpl_) SQLInt32(ctx *sql.Context, dest []byte, v interface{})
 	if err != nil {
 		return nil, err
 	}
-	if num > (1<<23 - 1) {
-		num = int64(1<<23 - 1)
-	} else if num < (-1 << 23) {
-		num = int64(-1 << 23)
+	if num > math.MaxInt32 {
+		num = math.MaxInt32
+	} else if num < math.MinInt32 {
+		num = math.MinInt32
 	}
 	dest = strconv.AppendInt(dest, num, 10)
 	return dest, nil

sql/types/number_test.go

@@ -177,6 +177,7 @@ func TestNumberConvert(t *testing.T) {
 		{typ: Int16, inp: uint16(1), exp: int16(1), err: false, inRange: sql.InRange},
 		{typ: Int24, inp: false, exp: int32(0), err: false, inRange: sql.InRange},
 		{typ: Int32, inp: nil, exp: nil, err: false, inRange: sql.InRange},
+		{typ: Int32, inp: 2147483647, exp: int32(2147483647), err: false, inRange: sql.InRange},
 		{typ: Int64, inp: "33", exp: int64(33), err: false, inRange: sql.InRange},
 		{typ: Int64, inp: "33.0", exp: int64(33), err: false, inRange: sql.InRange},
 		{typ: Int64, inp: "33.1", exp: int64(33), err: false, inRange: sql.InRange},