last attempt

James Cor · James Cor · commit 89738317e7fe · 2025-07-21T12:08:57.000-07:00
diff --git a/sql/analyzer/replace_sort.go b/sql/analyzer/replace_sort.go
@@ -162,7 +162,7 @@ func replaceIdxSortHelper(ctx *sql.Context, scope *plan.Scope, node sql.Node, so
 		case *plan.JoinNode:
 			// TODO: is this applicable to other types of joins?
 			//   as long as left child is already sorted and SortFields are a prefix, then it's ok?
-			if !c.JoinType().IsMerge() {
+			if c.JoinType() != plan.JoinTypeMerge {
 				continue
 			}
 			// It's (probably) not possible to have Sort as child of Join without Subquery/SubqueryAlias,

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ func replaceIdxSortHelper(ctx sql.Context, scope plan.Scope, node sql.Node, so`
`162`	`162`	`case *plan.JoinNode:`
`163`	`163`	`// TODO: is this applicable to other types of joins?`
`164`	`164`	`// as long as left child is already sorted and SortFields are a prefix, then it's ok?`
`165`		`- if !c.JoinType().IsMerge() {`
	`165`	`+ if c.JoinType() != plan.JoinTypeMerge {`
`166`	`166`	`continue`
`167`	`167`	`}`
`168`	`168`	`// It's (probably) not possible to have Sort as child of Join without Subquery/SubqueryAlias,`