Merge pull request #1853 from testwill/replace-loop

chore: slice replace loop

Author: zachmu

memory/database.go

@@ -251,9 +251,7 @@ func (d *BaseDatabase) RenameTable(ctx *sql.Context, oldName, newName string) er
 
 func (d *BaseDatabase) GetTriggers(ctx *sql.Context) ([]sql.TriggerDefinition, error) {
 	var triggers []sql.TriggerDefinition
-	for _, def := range d.triggers {
-		triggers = append(triggers, def)
-	}
+	triggers = append(triggers, d.triggers...)
 	return triggers, nil
 }
 
@@ -291,9 +289,7 @@ func (d *BaseDatabase) GetStoredProcedure(ctx *sql.Context, name string) (sql.St
 // GetStoredProcedures implements sql.StoredProcedureDatabase
 func (d *BaseDatabase) GetStoredProcedures(ctx *sql.Context) ([]sql.StoredProcedureDetails, error) {
 	var spds []sql.StoredProcedureDetails
-	for _, spd := range d.storedProcedures {
-		spds = append(spds, spd)
-	}
+	spds = append(spds, d.storedProcedures...)
 	return spds, nil
 }
 
@@ -340,9 +336,7 @@ func (d *BaseDatabase) GetEvent(ctx *sql.Context, name string) (sql.EventDefinit
 // GetEvents implements sql.EventDatabase
 func (d *BaseDatabase) GetEvents(ctx *sql.Context) ([]sql.EventDefinition, error) {
 	var eds []sql.EventDefinition
-	for _, ed := range d.events {
-		eds = append(eds, ed)
-	}
+	eds = append(eds, d.events...)
 	return eds, nil
 }
 

sql/in_mem_table/data.go

@@ -272,9 +272,7 @@ func (data *Data) ToSlice(ctx *sql.Context) []Entry {
 	var entries []Entry
 	for _, indexedData := range data.data {
 		for _, ourEntries := range indexedData {
-			for _, entry := range ourEntries {
-				entries = append(entries, entry)
-			}
+			entries = append(entries, ourEntries...)
 		}
 		break
 	}

sql/information_schema/information_schema.go

@@ -2806,9 +2806,7 @@ func viewsInDatabase(ctx *Context, db Database) ([]ViewDefinition, error) {
 			return nil, err
 		}
 
-		for _, view := range dbViews {
-			views = append(views, view)
-		}
+		views = append(views, dbViews...)
 	}
 
 	for _, view := range ctx.GetViewRegistry().ViewsInDatabase(dbName) {

sql/plan/indexed_table_access.go

@@ -245,9 +245,7 @@ func (i *IndexedTableAccess) String() string {
 
 func formatIndexDecoratorString(idx sql.Index) string {
 	var expStrs []string
-	for _, e := range idx.Expressions() {
-		expStrs = append(expStrs, e)
-	}
+	expStrs = append(expStrs, idx.Expressions()...)
 	return fmt.Sprintf("[%s]", strings.Join(expStrs, ","))
 }
 

sql/rowexec/window_test.go

@@ -77,9 +77,7 @@ func TestWindowPlanToIter(t *testing.T) {
 	require.Equal(t, len(outputOrdinals), 3)
 	accOrdinals := make([]int, 0)
 	for _, p := range outputOrdinals {
-		for _, v := range p {
-			accOrdinals = append(accOrdinals, v)
-		}
+		accOrdinals = append(accOrdinals, p...)
 	}
 	require.ElementsMatch(t, accOrdinals, []int{0, 1, 2, 3})