fixing more tests

Author: James Cor

sql/expression/function/str_to_date_test.go

@@ -20,25 +20,22 @@ func TestStrToDate(t *testing.T) {
 		fmtStr   string
 		expected interface{}
 	}{
-		{"standard", "Dec 26, 2000 2:13:15", "%b %e, %Y %T", "2000-12-26 02:13:15"},
-		{"ymd", "20240101", "%Y%m%d", "2024-01-01"},
-		{"ymd", "2024121", "%Y%m%d", "2024-12-01"},
+		{"standard", "Dec 26, 2000 2:13:15", "%b %e, %Y %T", time.Date(2000, time.December, 26, 2, 13, 15, 0, time.UTC)},
+		{"ymd", "20240101", "%Y%m%d", time.Date(2024, time.January, 1, 0, 0, 0, 0, time.UTC)},
+		{"ymd", "2024121", "%Y%m%d", time.Date(2024, time.December, 1, 0, 0, 0, 0, time.UTC)},
 		{"ymd", "20241301", "%Y%m%d", nil},
 		{"ymd", "20240001", "%Y%m%d", nil},
-		{"ymd-with-time", "2024010203:04:05", "%Y%m%d%T", "2024-01-02 03:04:05"},
-		{"ymd-with-time", "202408122:03:04", "%Y%m%d%T", "2024-08-12 02:03:04"},
+		{"ymd-with-time", "2024010203:04:05", "%Y%m%d%T", time.Date(2024, time.January, 2, 3, 4, 5, 0, time.UTC)},
+		{"ymd-with-time", "202408122:03:04", "%Y%m%d%T", time.Date(2024, time.August, 12, 2, 3, 4, 0, time.UTC)},
 		// TODO: It shoud be nil, but returns "2024-02-31"
 		// {"ymd", "20240231", "%Y%m%d", nil},
 	}
 
 	for _, tt := range testCases {
-		f, err := NewStrToDate(
+		f := NewStrToDate(
 			expression.NewGetField(0, types.Text, "", true),
 			expression.NewGetField(1, types.Text, "", true),
 		)
-		if err != nil {
-			t.Fatal(err)
-		}
 		t.Run(tt.name, func(t *testing.T) {
 			dtime := eval(t, f, sql.NewRow(tt.dateStr, tt.fmtStr))
 			require.Equal(t, tt.expected, dtime)
@@ -60,13 +57,10 @@ func TestStrToDateFailure(t *testing.T) {
 	}
 
 	for _, tt := range testCases {
-		f, err := NewStrToDate(
+		f := NewStrToDate(
 			expression.NewGetField(0, types.Text, "", true),
 			expression.NewGetField(1, types.Text, "", true),
 		)
-		if err != nil {
-			t.Fatal(err)
-		}
 		t.Run(tt.name, func(t *testing.T) {
 			dtime := eval(t, f, sql.NewRow(tt.dateStr, tt.fmtStr))
 			require.Equal(t, nil, dtime)