feedback

James Cor · James Cor · commit 982897fce598 · 2025-08-12T13:52:08.000-07:00
diff --git a/sql/iters/rel_iters.go b/sql/iters/rel_iters.go
@@ -167,8 +167,6 @@ type JsonTableCol struct {
 	pos      int
 	finished bool // exhausted all rows in data
 	currSib  int
-
-	resultRow sql.Row
 }
 
 // IsSibling returns if the jsonTableCol contains multiple columns
diff --git a/sql/rowexec/join_iters.go b/sql/rowexec/join_iters.go
@@ -647,7 +647,6 @@ func (i *crossJoinIterator) Next(ctx *sql.Context) (sql.Row, error) {
 			}
 			copy(i.primaryRow[i.parentLen:], r)
 
-			// TODO: do we need to keep rebuilding? there's no condition, so i.leftRow shouldn't produce a new iter right?
 			iter, err := i.b.Build(ctx, i.rp, i.primaryRow)
 			if err != nil {
 				return nil, err

Original file line number	Diff line number	Diff line change
`@@ -167,8 +167,6 @@ type JsonTableCol struct {`
`167`	`167`	`pos int`
`168`	`168`	`finished bool // exhausted all rows in data`
`169`	`169`	`currSib int`
`170`		`-`
`171`		`- resultRow sql.Row`
`172`	`170`	`}`
`173`	`171`
`174`	`172`	`// IsSibling returns if the jsonTableCol contains multiple columns`
Original file line number	Diff line number	Diff line change
`@@ -647,7 +647,6 @@ func (i crossJoinIterator) Next(ctx sql.Context) (sql.Row, error) {`
`647`	`647`	`}`
`648`	`648`	`copy(i.primaryRow[i.parentLen:], r)`
`649`	`649`
`650`		`- // TODO: do we need to keep rebuilding? there's no condition, so i.leftRow shouldn't produce a new iter right?`
`651`	`650`	`iter, err := i.b.Build(ctx, i.rp, i.primaryRow)`
`652`	`651`	`if err != nil {`
`653`	`652`	`return nil, err`