add tests

Author: elianddb

enginetest/memory_engine_test.go

@@ -200,24 +200,103 @@ func TestSingleQueryPrepared(t *testing.T) {
 
 // Convenience test for debugging a single query. Unskip and set to the desired query.
 func TestSingleScript(t *testing.T) {
-	t.Skip()
+	// t.Skip()
 	var scripts = []queries.ScriptTest{
 		{
-			Name:        "AS OF propagates to nested CALLs",
+			Name:        "Reproduction test for issue 9872: TEXT(m) syntax support",
 			SetUpScript: []string{},
 			Assertions: []queries.ScriptTestAssertion{
 				{
-					Query: "create procedure create_proc() create table t (i int primary key, j int);",
+					// https://github.com/dolthub/dolt/issues/9872 - Support for mysql `Text(m)` syntax
+					Query: "CREATE TABLE task_instance_note (ti_id VARCHAR(36) NOT NULL, user_id VARCHAR(128), content TEXT(1000), created_at TIMESTAMP(6) NOT NULL, updated_at TIMESTAMP(6) NOT NULL, CONSTRAINT task_instance_note_pkey PRIMARY KEY (ti_id))",
+					Expected: []sql.Row{
+						{types.NewOkResult(0)},
+					},
+				},
+				{
+					Query: "CREATE TABLE test_text_small (id INT PRIMARY KEY, small_text TEXT(255))",
+					Expected: []sql.Row{
+						{types.NewOkResult(0)},
+					},
+				},
+				{
+					Query: "CREATE TABLE test_text_large (id INT PRIMARY KEY, large_text TEXT(65535))",
+					Expected: []sql.Row{
+						{types.NewOkResult(0)},
+					},
+				},
+				{
+					Query: "CREATE TABLE test_text_medium (id INT PRIMARY KEY, medium_text TEXT(16777215))",
+					Expected: []sql.Row{
+						{types.NewOkResult(0)},
+					},
+				},
+				{
+					Query: "CREATE TABLE test_text_10k (id INT PRIMARY KEY, text_10k TEXT(10000))",
 					Expected: []sql.Row{
 						{types.NewOkResult(0)},
 					},
 				},
 				{
-					Query: "call create_proc()",
+					Query: "CREATE TABLE test_text_100k (id INT PRIMARY KEY, text_100k TEXT(100000))",
 					Expected: []sql.Row{
 						{types.NewOkResult(0)},
 					},
 				},
+				{
+					Query: "CREATE TABLE test_text_1m (id INT PRIMARY KEY, text_1m TEXT(1000000))",
+					Expected: []sql.Row{
+						{types.NewOkResult(0)},
+					},
+				},
+				{
+					Query: "CREATE TABLE test_text_no_length (id INT PRIMARY KEY, text_no_length TEXT)",
+					Expected: []sql.Row{
+						{types.NewOkResult(0)},
+					},
+				},
+				{
+					Query: "DESCRIBE test_text_small",
+					Expected: []sql.Row{
+						{"id", "int", "NO", "PRI", nil, ""},
+						{"small_text", "text", "YES", "", nil, ""},
+					},
+				},
+				{
+					Query: "DESCRIBE test_text_large",
+					Expected: []sql.Row{
+						{"id", "int", "NO", "PRI", nil, ""},
+						{"large_text", "mediumtext", "YES", "", nil, ""},
+					},
+				},
+				{
+					Query: "DESCRIBE test_text_medium",
+					Expected: []sql.Row{
+						{"id", "int", "NO", "PRI", nil, ""},
+						{"medium_text", "longtext", "YES", "", nil, ""},
+					},
+				},
+				{
+					Query: "DESCRIBE test_text_10k",
+					Expected: []sql.Row{
+						{"id", "int", "NO", "PRI", nil, ""},
+						{"text_10k", "text", "YES", "", nil, ""},
+					},
+				},
+				{
+					Query: "DESCRIBE test_text_100k",
+					Expected: []sql.Row{
+						{"id", "int", "NO", "PRI", nil, ""},
+						{"text_100k", "mediumtext", "YES", "", nil, ""},
+					},
+				},
+				{
+					Query: "DESCRIBE test_text_1m",
+					Expected: []sql.Row{
+						{"id", "int", "NO", "PRI", nil, ""},
+						{"text_1m", "mediumtext", "YES", "", nil, ""},
+					},
+				},
 			},
 		},
 	}

sql/types/conversion.go

@@ -268,7 +268,17 @@ func ColumnTypeToType(ct *sqlparser.ColumnType) (sql.Type, error) {
 		if err != nil {
 			return nil, err
 		}
-		return CreateString(sqltypes.Text, length, collation)
+		// MySQL automatically chooses the appropriate TEXT type based on length
+		// TEXT(1) to TEXT(65534) → text (65535 max)
+		// TEXT(65535) to TEXT(16777215) → mediumtext (16777215 max)
+		// TEXT(16777216) to TEXT(4294967295) → longtext (4294967295 max)
+		if length < TextBlobMax {
+			return CreateString(sqltypes.Text, TextBlobMax/collation.CharacterSet().MaxLength(), collation)
+		} else if length <= MediumTextBlobMax {
+			return CreateString(sqltypes.Text, MediumTextBlobMax/collation.CharacterSet().MaxLength(), collation)
+		} else {
+			return CreateString(sqltypes.Text, LongTextBlobMax/collation.CharacterSet().MaxLength(), collation)
+		}
 	case "mediumtext", "mediumblob", "long", "long varchar":
 		collation, err := sql.ParseCollation(ct.Charset, collate, ct.BinaryCollate)
 		if err != nil {