Propagate context parameter.

Author: nicktobey

memory/table_data.go

@@ -139,7 +139,7 @@ func (td TableData) partition(ctx *sql.Context, row sql.Row) (int, error) {
 
 		t, isStringType := td.schema.Schema[keyColumns[i]].Type.(sql.StringType)
 		if isStringType && v != nil {
-			v, err = types.ConvertToString(v, t, nil)
+			v, err = types.ConvertToString(ctx, v, t, nil)
 			if err == nil {
 				err = t.Collation().WriteWeightString(hash, v.(string))
 			}

sql/expression/function/inet_convert.go

@@ -81,7 +81,7 @@ func (i *InetAton) Eval(ctx *sql.Context, row sql.Row) (interface{}, error) {
 	}
 
 	// Expect to receive an IP address, so convert val into string
-	ipstr, err := types.ConvertToString(val, types.LongText, nil)
+	ipstr, err := types.ConvertToString(ctx, val, types.LongText, nil)
 	if err != nil {
 		return nil, sql.ErrInvalidType.New(reflect.TypeOf(val).String())
 	}

sql/expression/function/locks.go

@@ -77,7 +77,7 @@ func (nl *NamedLockFunction) GetLockName(ctx *sql.Context, row sql.Row) (*string
 	if !ok {
 		return nil, ErrIllegalLockNameArgType.New(nl.Child.Type().String(), nl.funcName)
 	}
-	lockName, err := types.ConvertToString(val, s, nil)
+	lockName, err := types.ConvertToString(ctx, val, s, nil)
 	if err != nil {
 		return nil, fmt.Errorf("%w; %s", ErrIllegalLockNameArgType.New(nl.Child.Type().String(), nl.funcName), err)
 	}
@@ -328,7 +328,7 @@ func (gl *GetLock) Eval(ctx *sql.Context, row sql.Row) (interface{}, error) {
 		return nil, ErrIllegalLockNameArgType.New(gl.LeftChild.Type().String(), gl.FunctionName())
 	}
 
-	lockName, err := types.ConvertToString(leftVal, s, nil)
+	lockName, err := types.ConvertToString(ctx, leftVal, s, nil)
 	if err != nil {
 		return nil, fmt.Errorf("%w; %s", ErrIllegalLockNameArgType.New(gl.LeftChild.Type().String(), gl.FunctionName()), err)
 	}

sql/rowexec/agg.go

@@ -259,7 +259,7 @@ func groupingKey(
 
 		t, isStringType := expr.Type().(sql.StringType)
 		if isStringType && v != nil {
-			v, err = types.ConvertToString(v, t, nil)
+			v, err = types.ConvertToString(ctx, v, t, nil)
 			if err == nil {
 				err = t.Collation().WriteWeightString(hash, v.(string))
 			}

sql/types/strings.go

@@ -319,6 +319,8 @@ func (t StringType) Compare(a interface{}, b interface{}) (int, error) {
 
 // Convert implements Type interface.
 func (t StringType) Convert(v interface{}) (interface{}, sql.ConvertInRange, error) {
+	// TODO: Add context parameter to Convert
+	ctx := context.Background()
 	if v == nil {
 		return nil, sql.InRange, nil
 	}
@@ -333,7 +335,7 @@ func (t StringType) Convert(v interface{}) (interface{}, sql.ConvertInRange, err
 			return v, sql.InRange, nil
 		}
 	}
-	val, err := ConvertToBytes(v, t, nil)
+	val, err := ConvertToBytes(ctx, v, t, nil)
 	if err != nil {
 		return nil, sql.OutOfRange, err
 	}
@@ -349,12 +351,12 @@ func (t StringType) Convert(v interface{}) (interface{}, sql.ConvertInRange, err
 
 }
 
-func ConvertToString(v interface{}, t sql.StringType, dest []byte) (string, error) {
-	ret, err := ConvertToBytes(v, t, dest)
+func ConvertToString(ctx context.Context, v interface{}, t sql.StringType, dest []byte) (string, error) {
+	ret, err := ConvertToBytes(ctx, v, t, dest)
 	return string(ret), err
 }
 
-func ConvertToBytes(v interface{}, t sql.StringType, dest []byte) ([]byte, error) {
+func ConvertToBytes(ctx context.Context, v interface{}, t sql.StringType, dest []byte) ([]byte, error) {
 	var val []byte
 	start := len(dest)
 	switch s := v.(type) {
@@ -418,12 +420,11 @@ func ConvertToBytes(v interface{}, t sql.StringType, dest []byte) ([]byte, error
 		}
 		val = append(dest, st...)
 	case sql.AnyWrapper:
-		//TODO: Propagate context
-		unwrapped, err := s.UnwrapAny(context.Background())
+		unwrapped, err := s.UnwrapAny(ctx)
 		if err != nil {
 			return nil, err
 		}
-		val, err = ConvertToBytes(unwrapped, t, dest)
+		val, err = ConvertToBytes(ctx, unwrapped, t, dest)
 		if err != nil {
 			return nil, err
 		}
@@ -566,7 +567,7 @@ func (t StringType) SQL(ctx *sql.Context, dest []byte, v interface{}) (sqltypes.
 	start := len(dest)
 	var val []byte
 	if IsBinaryType(t) {
-		val, err = ConvertToBytes(v, t, dest)
+		val, err = ConvertToBytes(ctx, v, t, dest)
 		if err != nil {
 			return sqltypes.Value{}, err
 		}
@@ -613,7 +614,7 @@ func (t StringType) SQL(ctx *sql.Context, dest []byte, v interface{}) (sqltypes.
 				valueBytes = valueBytes[start+1:]
 			}
 		default:
-			valueBytes, err = ConvertToBytes(v, t, dest)
+			valueBytes, err = ConvertToBytes(ctx, v, t, dest)
 		}
 		if t.baseType == sqltypes.Binary {
 			val = append(val, bytes.Repeat([]byte{0}, int(t.maxCharLength)-len(val))...)