Skip to content

Commit 99a392b

Browse files
committed
added some TODO comments
1 parent 14e51c1 commit 99a392b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

server/server.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ func portInUse(hostPort string) bool {
120120
}
121121

122122
func getPortOrDefault(cfg mysql.ListenerConfig) int64 {
123-
// TODO read this value from systemVars
123+
// TODO read this value from systemVars (different in postgres)
124124
defaultPort := int64(3606)
125125
_, port, err := net.SplitHostPort(cfg.Listener.Addr().String())
126126
if err != nil {
@@ -151,7 +151,7 @@ func updateSystemVariables(cfg mysql.ListenerConfig) error {
151151

152152
func newServerFromHandler(cfg Config, e *sqle.Engine, sm *SessionManager, handler mysql.Handler, sel ServerEventListener) (*Server, error) {
153153
oneSecond := time.Duration(1) * time.Second
154-
// TODO read default values from systemVars
154+
// TODO read default values from systemVars. some default values are different in postgres vs mysql
155155
if cfg.ConnReadTimeout < oneSecond {
156156
cfg.ConnReadTimeout = oneSecond * 30
157157
}

0 commit comments

Comments
 (0)