Skip to content

Commit 9a9790c

Browse files
committed
rm check for vt == 0
1 parent 5b27bf7 commit 9a9790c

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

sql/planbuilder/dml.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -215,19 +215,19 @@ func (b *Builder) buildInsertValues(inScope *scope, v *ast.AliasedValues, column
215215
exprTuples := make([][]sql.Expression, len(v.Values))
216216
for i, vt := range v.Values {
217217
// noExprs is an edge case where we fill VALUES with nil expressions
218-
noExprs := len(vt) == 0
218+
//noExprs := len(vt) == 0
219219
// triggerUnknownTable is an edge case where we ignored an unresolved
220220
// table error and do not have a schema for resolving defaults
221221
triggerUnknownTable := (len(columnNames) == 0 && len(vt) > 0) && (len(b.TriggerCtx().UnresolvedTables) > 0)
222222

223-
if len(vt) != len(columnNames) && !noExprs && !triggerUnknownTable {
224-
err := sql.ErrInsertIntoMismatchValueCount.New()
223+
if len(vt) != len(columnNames) && !triggerUnknownTable {
224+
err := sql.ErrColumnCountMismatch.New()
225225
b.handleErr(err)
226226
}
227227
exprs := make([]sql.Expression, len(columnNames))
228228
exprTuples[i] = exprs
229229
for j := range columnNames {
230-
if noExprs || triggerUnknownTable {
230+
if triggerUnknownTable {
231231
exprs[j] = expression.WrapExpression(columnDefaultValues[j])
232232
continue
233233
}

0 commit comments

Comments
 (0)