[no-release-notes] tidy up analyzer (#2707)

Author: jycor

sql/analyzer/aggregations.go

@@ -294,25 +294,6 @@ func aliasedExpressionsInNode(n sql.Node) map[string]string {
 	return aliasesFromExpressionToName
 }
 
-// aliasesDefinedInNode returns the expression aliases that are defined in the first Projector node found, starting
-// the search from the specified node. All returned alias names are normalized to lower case.
-func aliasesDefinedInNode(n sql.Node) []string {
-	projector := findFirstProjectorNode(n)
-	if projector == nil {
-		return nil
-	}
-
-	var aliases []string
-	for _, e := range projector.ProjectedExprs() {
-		alias, ok := e.(*expression.Alias)
-		if ok {
-			aliases = append(aliases, strings.ToLower(alias.Name()))
-		}
-	}
-
-	return aliases
-}
-
 // normalizeExpressions returns the expressions given after normalizing them to replace table and expression aliases
 // with their underlying names. This is necessary to match such expressions against those declared by implementors of
 // various interfaces that declare expressions to handle, such as Index.Expressions(), FilteredTable, etc.

sql/analyzer/aliases.go

@@ -518,7 +518,7 @@ func (a *Analyzer) analyzeWithSelector(ctx *sql.Context, n sql.Node, scope *plan
 	a.LogNode(n)
 
 	batches := a.Batches
-	if b, ok := getBatchesForNode(n, batches); ok {
+	if b, ok := getBatchesForNode(n); ok {
 		batches = b
 	}
 

sql/analyzer/analyzer.go

@@ -32,17 +32,3 @@ func addAutocommit(ctx *sql.Context, a *Analyzer, n sql.Node, scope *plan.Scope,
 	}
 	return plan.NewTransactionCommittingNode(n), transform.NewTree, nil
 }
-
-func hasShowWarningsNode(n sql.Node) bool {
-	var ret bool
-	transform.Inspect(n, func(n sql.Node) bool {
-		if _, ok := n.(plan.ShowWarnings); ok {
-			ret = true
-			return false
-		}
-
-		return true
-	})
-
-	return ret
-}

sql/analyzer/autocommit.go

@@ -1387,24 +1387,3 @@ func isWeaklyMonotonic(e sql.Expression) bool {
 		}
 	})
 }
-
-// attrsRefSingleTableCol returns false if there are
-// getFields sourced from zero or more than one table.
-func attrsRefSingleTableCol(e sql.Expression) (tableCol, bool) {
-	var tc tableCol
-	var invalid bool
-	transform.InspectExpr(e, func(e sql.Expression) bool {
-		switch e := e.(type) {
-		case *expression.GetField:
-			newTc := newTableCol(e.Table(), e.Name())
-			if tc.table == "" && !invalid {
-				tc = newTc
-			} else if tc != newTc {
-				invalid = true
-			}
-		default:
-		}
-		return invalid
-	})
-	return tc, !invalid && tc.table != ""
-}

sql/analyzer/indexed_joins.go

@@ -331,27 +331,3 @@ func isAutoUuidColumn(col *sql.Column) bool {
 
 	return false
 }
-
-// validGeneratedColumnValue returns true if the column is a generated column and the source node is not a values node.
-// Explicit default values (`DEFAULT`) are the only valid values to specify for a generated column
-func validGeneratedColumnValue(idx int, source sql.Node) bool {
-	switch source := source.(type) {
-	case *plan.Values:
-		for _, tuple := range source.ExpressionTuples {
-			switch val := tuple[idx].(type) {
-			case *sql.ColumnDefaultValue: // should be wrapped, but just in case
-				return true
-			case *expression.Wrapper:
-				if _, ok := val.Unwrap().(*sql.ColumnDefaultValue); ok {
-					return true
-				}
-				return false
-			default:
-				return false
-			}
-		}
-		return false
-	default:
-		return false
-	}
-}

sql/analyzer/inserts.go

@@ -7,8 +7,8 @@ import (
 
 // getBatchesForNode returns a partial analyzer ruleset for simple node
 // types that require little prior validation before execution.
-func getBatchesForNode(n sql.Node, orig []*Batch) ([]*Batch, bool) {
-	switch n := n.(type) {
+func getBatchesForNode(node sql.Node) ([]*Batch, bool) {
+	switch n := node.(type) {
 	case *plan.Commit:
 		return nil, true
 	case *plan.StartTransaction: