Skip to content

Commit 9ae1a2f

Browse files
authored
Merge pull request #3107 from dolthub/jennifer/fix
change Compute method signature to return error separately for window functions
2 parents 75c0b19 + 042c4c4 commit 9ae1a2f

File tree

5 files changed

+102
-97
lines changed

5 files changed

+102
-97
lines changed

sql/aggregates.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ type WindowFunction interface {
4949
// TODO: implement sliding window interface in aggregation functions and windowBlockIter
5050
// NewSlidingFrameInterval(added, dropped WindowInterval)
5151
// Compute returns an aggregation result for a given interval and buffer
52-
Compute(*Context, WindowInterval, WindowBuffer) interface{}
52+
Compute(*Context, WindowInterval, WindowBuffer) (interface{}, error)
5353
}
5454

5555
// WindowAdaptableExpression is an Expression that can be executed as a window aggregation

0 commit comments

Comments
 (0)