remove duplicate getTableName function

Author: angelamayxie

sql/analyzer/tables.go

@@ -22,7 +22,7 @@ import (
 	"github.com/dolthub/go-mysql-server/sql/transform"
 )
 
-// Returns the underlying table name for the node given
+// Returns the underlying table name, unaliased, for the node given
 func getTableName(node sql.Node) string {
 	var tableName string
 	transform.Inspect(node, func(node sql.Node) bool {
@@ -43,27 +43,6 @@ func getTableName(node sql.Node) string {
 	return tableName
 }
 
-// Returns the underlying table name for the node given, ignoring table aliases
-func getUnaliasedTableName(node sql.Node) string {
-	var tableName string
-	transform.Inspect(node, func(node sql.Node) bool {
-		switch node := node.(type) {
-		case *plan.ResolvedTable:
-			tableName = node.Name()
-			return false
-		case *plan.UnresolvedTable:
-			tableName = node.Name()
-			return false
-		case *plan.IndexedTableAccess:
-			tableName = node.Name()
-			return false
-		}
-		return true
-	})
-
-	return tableName
-}
-
 // Finds first table node that is a descendant of the node given
 func getTable(node sql.Node) sql.Table {
 	var table sql.Table

sql/analyzer/triggers.go

@@ -512,8 +512,8 @@ func validateNoCircularUpdates(trigger *plan.CreateTrigger, n sql.Node, scope *p
 		switch node := node.(type) {
 		case *plan.Update, *plan.InsertInto, *plan.DeleteFrom:
 			for _, n := range append([]sql.Node{n}, scope.MemoNodes()...) {
-				invokingTableName := getUnaliasedTableName(n)
-				updatedTable := getUnaliasedTableName(node)
+				invokingTableName := getTableName(n)
+				updatedTable := getTableName(node)
 				// TODO: need to compare DB as well
 				if updatedTable == invokingTableName {
 					circularRef = sql.ErrTriggerTableInUse.New(updatedTable)