Skip to content

Commit a268496

Browse files
elianddbclaude
andcommitted
Un-skip auto-increment overflow tests from PR #3100
Removed Skip: true from tests that verify auto-increment behavior at maximum values. Our fix now allows these tests to pass: - Insert max values (127 for TINYINT, 32767 for SMALLINT, etc.) - Verify SHOW CREATE TABLE shows correct AUTO_INCREMENT values - Removed redundant auto_increment_overflow_test.go file Tests now properly validate that AUTO_INCREMENT values don't exceed type limits and display correctly in SHOW CREATE TABLE output. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 6bf4121 commit a268496

File tree

2 files changed

+1
-123
lines changed

2 files changed

+1
-123
lines changed

enginetest/queries/auto_increment_overflow_test.go

Lines changed: 0 additions & 114 deletions
This file was deleted.

enginetest/queries/script_queries.go

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10417,7 +10417,6 @@ where
1041710417
ExpectedErr: sql.ErrValueOutOfRange,
1041810418
},
1041910419
{
10420-
Skip: true,
1042110420
Query: "insert into tinyint_tbl values (127)",
1042210421
Expected: []sql.Row{
1042310422
{types.OkResult{
@@ -10427,7 +10426,6 @@ where
1042710426
},
1042810427
},
1042910428
{
10430-
Skip: true,
1043110429
Query: "show create table tinyint_tbl;",
1043210430
Expected: []sql.Row{
1043310431
{"tinyint_tbl", "CREATE TABLE `tinyint_tbl` (\n" +
@@ -10443,7 +10441,6 @@ where
1044310441
ExpectedErr: sql.ErrValueOutOfRange,
1044410442
},
1044510443
{
10446-
Skip: true,
1044710444
Query: "insert into smallint_tbl values (32767);",
1044810445
Expected: []sql.Row{
1044910446
{types.OkResult{
@@ -10453,13 +10450,12 @@ where
1045310450
},
1045410451
},
1045510452
{
10456-
Skip: true,
1045710453
Query: "show create table smallint_tbl;",
1045810454
Expected: []sql.Row{
1045910455
{"smallint_tbl", "CREATE TABLE `smallint_tbl` (\n" +
1046010456
" `i` smallint NOT NULL AUTO_INCREMENT,\n" +
1046110457
" PRIMARY KEY (`i`)\n" +
10462-
") ENGINE=InnoDB AUTO_INCREMENT=36727 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_bin"},
10458+
") ENGINE=InnoDB AUTO_INCREMENT=32767 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_bin"},
1046310459
},
1046410460
},
1046510461

@@ -10495,7 +10491,6 @@ where
1049510491
ExpectedErr: sql.ErrValueOutOfRange,
1049610492
},
1049710493
{
10498-
Skip: true,
1049910494
Query: "insert into int_tbl values (2147483647)",
1050010495
Expected: []sql.Row{
1050110496
{types.OkResult{
@@ -10505,7 +10500,6 @@ where
1050510500
},
1050610501
},
1050710502
{
10508-
Skip: true,
1050910503
Query: "show create table int_tbl;",
1051010504
Expected: []sql.Row{
1051110505
{"int_tbl", "CREATE TABLE `int_tbl` (\n" +
@@ -10521,7 +10515,6 @@ where
1052110515
ExpectedErr: sql.ErrValueOutOfRange,
1052210516
},
1052310517
{
10524-
Skip: true,
1052510518
Query: "insert into bigint_tbl values (9223372036854775807);",
1052610519
Expected: []sql.Row{
1052710520
{types.OkResult{
@@ -10531,7 +10524,6 @@ where
1053110524
},
1053210525
},
1053310526
{
10534-
Skip: true,
1053510527
Query: "show create table bigint_tbl;",
1053610528
Expected: []sql.Row{
1053710529
{"bigint_tbl", "CREATE TABLE `bigint_tbl` (\n" +

0 commit comments

Comments
 (0)