tidy

Author: James Cor

enginetest/enginetests.go

@@ -5834,7 +5834,6 @@ func TestTypesOverWire(t *testing.T, harness ClientHarness, sessionBuilder serve
 					require.NoError(t, err)
 					expectedRowSet := script.Results[queryIdx]
 					expectedRowIdx := 0
-					buf := sql.NewByteBuffer(1000)
 					var engineRow sql.Row
 					for engineRow, err = engineIter.Next(ctx); err == nil; engineRow, err = engineIter.Next(ctx) {
 						if !assert.True(t, r.Next()) {
@@ -5852,7 +5851,7 @@ func TestTypesOverWire(t *testing.T, harness ClientHarness, sessionBuilder serve
 							break
 						}
 						expectedEngineRow := make([]*string, len(engineRow))
-						row, err := server.RowToSQL(ctx, sch, engineRow, nil, buf)
+						row, _, err := server.RowToSQL(ctx, sch, engineRow, nil, nil)
 						if !assert.NoError(t, err) {
 							break
 						}

server/handler.go

@@ -1261,6 +1261,7 @@ func getMaxTypeCapacity(ctx *sql.Context, typ sql.Type) (res int) {
 	case sqltypes.Bit:
 		res = int(typ.MaxTextResponseByteLength(ctx))
 	default:
+		// TODO: StringType can use backing array depending on the type of
 		// These types do not use sql.ByteBuffer
 		res = 0
 	}

sql/types/sql_test.go

@@ -24,7 +24,7 @@ func BenchmarkNumI64SQL(b *testing.B) {
 func BenchmarkVarchar10SQL(b *testing.B) {
 	var res sqltypes.Value
 	t := MustCreateStringWithDefaults(sqltypes.VarChar, 10)
-	buf := sql.NewByteBuffer(1000)
+	buf := sql.NewByteBuffer()
 	ctx := sql.NewEmptyContext()
 	for i := 0; i < b.N; i++ {
 		res, _ = t.SQL(ctx, buf.Get(), "char")