PR feedback

Author: zachmu

go.mod

@@ -42,4 +42,8 @@ require (
 	gopkg.in/check.v1 v1.0.0-20200902074654-038fdea0a05b // indirect
 )
 
+replace github.com/dolthub/vitess => ../vitess
+
+replace github.com/dolthub/vitess => ../vitess
+
 go 1.23.3

sql/plan/alter_foreign_key.go

@@ -546,7 +546,7 @@ func FindForeignKeyColMapping(
 		indexPos, ok := indexColMap[destFkCol]
 		if !ok {
 			// Same as above, renaming a referenced column would cause this error
-			return nil, nil, fmt.Errorf("inde	x column `%s` in foreign key `%s` cannot be found",
+			return nil, nil, fmt.Errorf("index column `%s` in foreign key `%s` cannot be found",
 				destFKCols[fkIdx], fkName)
 		}
 		indexPositions[indexPos] = localRowPos

sql/plan/foreign_key_editor.go

@@ -598,15 +598,15 @@ func GetForeignKeyTypeConversions(
 		childType := childSch[childIndex].Type
 		parentType := parentSch[parentIndex].Type
 
-		childExtendedType, _ := childType.(types.ExtendedType)
+		childExtendedType, ok := childType.(types.ExtendedType)
 		// if even one of the types is not an extended type, then we can't transform any values
-		if childExtendedType == nil {
+		if !ok {
 			return nil, nil
 		}
 
 		if !childType.Equals(parentType) {
-			parentExtendedType, _ := parentType.(types.ExtendedType)
-			if parentExtendedType == nil {
+			parentExtendedType, ok := parentType.(types.ExtendedType)
+			if !ok {
 				// this should be impossible (child and parent should both be extended types), but just in case
 				return nil, nil
 			}