mv to one loop pk applier

Author: elianddb

sql/analyzer/resolve_create_select.go

@@ -39,38 +39,26 @@ func resolveCreateSelect(ctx *sql.Context, a *Analyzer, n sql.Node, scope *plan.
 	}
 
 	// Apply primary key constraints from index definitions to the merged schema
-	pkOrdinals := make([]int, 0)
 	var nonPkIndexes sql.IndexDefs
 	for _, idx := range ct.Indexes() {
 		if idx.IsPrimary() {
 			for _, idxCol := range idx.Columns {
 				for i, schCol := range newSch {
 					if schCol.Name == idxCol.Name {
 						newSch[i].PrimaryKey = true
-						pkOrdinals = append(pkOrdinals, i)
 						break
 					}
 				}
 			}
 		} else {
-			// Keep non-primary key indexes
 			nonPkIndexes = append(nonPkIndexes, idx)
 		}
 	}
-	
-	// Also check for columns already marked as primary key
+
+	pkOrdinals := make([]int, 0)
 	for i, col := range newSch {
 		if col.PrimaryKey {
-			found := false
-			for _, pk := range pkOrdinals {
-				if pk == i {
-					found = true
-					break
-				}
-			}
-			if !found {
-				pkOrdinals = append(pkOrdinals, i)
-			}
+			pkOrdinals = append(pkOrdinals, i)
 		}
 	}