Merge pull request #2986 from dolthub/jennifer/insert-into-returning

jennifersp · web-flow · commit b56c7c6eb677 · 2025-05-20T18:21:41.000-07:00
add returning clause case for assign exec index rule
diff --git a/sql/analyzer/fix_exec_indexes.go b/sql/analyzer/fix_exec_indexes.go
@@ -38,7 +38,7 @@ func assignExecIndexes(ctx *sql.Context, a *Analyzer, n sql.Node, scope *plan.Sc
 	}
 	switch n := n.(type) {
 	case *plan.InsertInto:
-		if n.LiteralValueSource && len(n.Checks()) == 0 && len(n.OnDupExprs) == 0 {
+		if n.LiteralValueSource && len(n.Checks()) == 0 && len(n.OnDupExprs) == 0 && len(n.Returning) == 0 {
 			return n, transform.SameTree, nil
 		}
 	case *plan.Update:

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ func assignExecIndexes(ctx sql.Context, a Analyzer, n sql.Node, scope *plan.Sc`
`38`	`38`	`}`
`39`	`39`	`switch n := n.(type) {`
`40`	`40`	`case *plan.InsertInto:`
`41`		`- if n.LiteralValueSource && len(n.Checks()) == 0 && len(n.OnDupExprs) == 0 {`
	`41`	`+ if n.LiteralValueSource && len(n.Checks()) == 0 && len(n.OnDupExprs) == 0 && len(n.Returning) == 0 {`
`42`	`42`	`return n, transform.SameTree, nil`
`43`	`43`	`}`
`44`	`44`	`case *plan.Update:`