remove duplicate conversion to string

angelamayxie · angelamayxie · commit b7bba455133a · 2025-07-30T10:55:18.000-07:00
diff --git a/sql/expression/convert.go b/sql/expression/convert.go
@@ -312,8 +312,7 @@ func convertValue(ctx *sql.Context, val interface{}, castTo string, originType s
 		}
 		return truncateConvertedValue(b, typeLength)
 	case ConvertToChar, ConvertToNChar:
-		val, _ = types.TypeAwareConversion(ctx, val, originType, types.LongText)
-		s, _, err := types.LongText.Convert(ctx, val)
+		s, err := types.TypeAwareConversion(ctx, val, originType, types.LongText)
 		if err != nil {
 			return nil, nil
 		}

Original file line number	Diff line number	Diff line change
`@@ -312,8 +312,7 @@ func convertValue(ctx *sql.Context, val interface{}, castTo string, originType s`
`312`	`312`	`}`
`313`	`313`	`return truncateConvertedValue(b, typeLength)`
`314`	`314`	`case ConvertToChar, ConvertToNChar:`
`315`		`- val, _ = types.TypeAwareConversion(ctx, val, originType, types.LongText)`
`316`		`- s, _, err := types.LongText.Convert(ctx, val)`
	`315`	`+ s, err := types.TypeAwareConversion(ctx, val, originType, types.LongText)`
`317`	`316`	`if err != nil {`
`318`	`317`	`return nil, nil`
`319`	`318`	`}`