Skip to content

Commit ba97442

Browse files
committed
rm fast path for virtual cols
1 parent 6256206 commit ba97442

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

sql/analyzer/fix_exec_indexes.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ func assignExecIndexes(ctx *sql.Context, a *Analyzer, n sql.Node, scope *plan.Sc
5353
}
5454
}
5555
case *plan.DeleteFrom:
56-
if n.RefsSingleRel && !n.HasExplicitTargets() && scope.IsEmpty() && !n.IsProcNested {
56+
if n.RefsSingleRel && !n.HasExplicitTargets() && scope.IsEmpty() && !n.IsProcNested && !n.Child.Schema().HasVirtualColumns() {
5757
// joins, subqueries, triggers, and procedures preclude fast indexing
5858
return offsetAssignIndexes(n), transform.NewTree, nil
5959
}

sql/plan/delete.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,10 +81,7 @@ func (p *DeleteFrom) WithTargets(targets []sql.Node) *DeleteFrom {
8181

8282
// GetDeleteTargets returns the sql.Nodes representing the tables from which rows should be deleted.
8383
func (p *DeleteFrom) GetDeleteTargets() []sql.Node {
84-
if len(p.targets) > 0 {
85-
return p.targets
86-
}
87-
return []sql.Node{p.Child}
84+
return p.targets
8885
}
8986

9087
// Schema implements the sql.Node interface.

0 commit comments

Comments
 (0)