fix test

James Cor · James Cor · commit bd3945d9b461 · 2025-09-05T17:35:48.000-07:00
diff --git a/sql/types/number.go b/sql/types/number.go
@@ -530,7 +530,7 @@ func (t NumberTypeImpl_) SQLUint64(ctx *sql.Context, dest []byte, v interface{})
 
 func (t NumberTypeImpl_) SQLFloat64(ctx *sql.Context, dest []byte, v interface{}) ([]byte, error) {
 	num, err := convertToFloat64(t, v)
-	if err != nil {
+	if err != nil && !sql.ErrDoubleTypeTruncated.Is(err) {
 		return nil, err
 	}
 	dest = strconv.AppendFloat(dest, num, 'g', -1, 64)
diff --git a/sql/types/number_test.go b/sql/types/number_test.go
@@ -253,7 +253,7 @@ func TestNumberSQL_NumberFromString(t *testing.T) {
 
 	val, err = Float64.SQL(sql.NewEmptyContext(), nil, "also not a number")
 	require.NoError(t, err)
-	assert.Equal(t, "also not a number", val.ToString())
+	assert.Equal(t, "0", val.ToString())
 }
 
 func TestNumberString(t *testing.T) {

Original file line number	Diff line number	Diff line change
`@@ -530,7 +530,7 @@ func (t NumberTypeImpl_) SQLUint64(ctx *sql.Context, dest []byte, v interface{})`
`530`	`530`
`531`	`531`	`func (t NumberTypeImpl_) SQLFloat64(ctx *sql.Context, dest []byte, v interface{}) ([]byte, error) {`
`532`	`532`	`num, err := convertToFloat64(t, v)`
`533`		`- if err != nil {`
	`533`	`+ if err != nil && !sql.ErrDoubleTypeTruncated.Is(err) {`
`534`	`534`	`return nil, err`
`535`	`535`	`}`
`536`	`536`	`dest = strconv.AppendFloat(dest, num, 'g', -1, 64)`
Original file line number	Diff line number	Diff line change
`@@ -253,7 +253,7 @@ func TestNumberSQL_NumberFromString(t *testing.T) {`
`253`	`253`
`254`	`254`	`val, err = Float64.SQL(sql.NewEmptyContext(), nil, "also not a number")`
`255`	`255`	`require.NoError(t, err)`
`256`		`- assert.Equal(t, "also not a number", val.ToString())`
	`256`	`+ assert.Equal(t, "0", val.ToString())`
`257`	`257`	`}`
`258`	`258`
`259`	`259`	`func TestNumberString(t *testing.T) {`