only update collation preference if text only

angelamayxie · angelamayxie · commit c0ce6d62896d · 2025-07-23T11:37:15.000-07:00
diff --git a/sql/expression/comparison.go b/sql/expression/comparison.go
@@ -151,7 +151,7 @@ func (c *comparison) Compare(ctx *sql.Context, row sql.Row) (int, error) {
 		return compareType.Compare(ctx, left, right)
 	}
 	collationPreference, _ := c.CollationCoercibility(ctx)
-	if stringCompareType, ok := compareType.(sql.StringType); ok {
+	if stringCompareType, ok := compareType.(sql.StringType); ok && types.IsTextOnly(stringCompareType) {
 		compareType = types.MustCreateString(stringCompareType.Type(), stringCompareType.Length(), collationPreference)
 	}
 	return compareType.Compare(ctx, l, r)

Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ func (c comparison) Compare(ctx sql.Context, row sql.Row) (int, error) {`
`151`	`151`	`return compareType.Compare(ctx, left, right)`
`152`	`152`	`}`
`153`	`153`	`collationPreference, _ := c.CollationCoercibility(ctx)`
`154`		`- if stringCompareType, ok := compareType.(sql.StringType); ok {`
	`154`	`+ if stringCompareType, ok := compareType.(sql.StringType); ok && types.IsTextOnly(stringCompareType) {`
`155`	`155`	`compareType = types.MustCreateString(stringCompareType.Type(), stringCompareType.Length(), collationPreference)`
`156`	`156`	`}`
`157`	`157`	`return compareType.Compare(ctx, l, r)`