Skip to content

Commit c216e59

Browse files
authored
Merge pull request #2844 from dolthub/zachmu/skip-transaction-test
Correctly skip skipped assertions in transaction tests
2 parents ace3b04 + cad92ac commit c216e59

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

enginetest/evaluation.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -301,6 +301,10 @@ func TestTransactionScriptWithEngine(t *testing.T, e QueryEngine, harness Harnes
301301
t.Skip()
302302
}
303303

304+
if assertion.Skip {
305+
t.Skip()
306+
}
307+
304308
if assertion.ExpectedErr != nil {
305309
AssertErrWithCtx(t, e, harness, clientSession, assertion.Query, assertion.Bindings, assertion.ExpectedErr)
306310
} else if assertion.ExpectedErrStr != "" {

0 commit comments

Comments
 (0)