Skip to content

Commit c3a64fe

Browse files
authored
Merge pull request #3212 from dolthub/angela/semi_merge
Wrap right side in Distinct when converting semi-joins to inner joins
2 parents 133fc3d + f0850da commit c3a64fe

File tree

10 files changed

+393
-511
lines changed

10 files changed

+393
-511
lines changed

enginetest/join_op_tests.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2009,8 +2009,6 @@ SELECT SUM(x) FROM xy WHERE x IN (
20092009
Expected: []sql.Row{{3}},
20102010
},
20112011
{
2012-
// TODO: this fails as a merge join. it seems related to https://github.com/dolthub/dolt/issues/9797
2013-
Skip: true,
20142012
Query: "select x from xy_hasnull_idx where exists(select 1 from rs where rs.s = xy_hasnull_idx.y)",
20152013
Expected: []sql.Row{{1}},
20162014
},
@@ -2025,7 +2023,6 @@ SELECT SUM(x) FROM xy WHERE x IN (
20252023
},
20262024
{
20272025
// https://github.com/dolthub/dolt/issues/9797
2028-
Skip: true,
20292026
Query: "select * from u where exists (select 1 from u as x where x.c0 = u.c0)",
20302027
Expected: []sql.Row{{1, 1}, {2, 2}, {2, 3}},
20312028
},

enginetest/queries/integration_plans.go

Lines changed: 68 additions & 102 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

enginetest/queries/query_plan_script_tests.go

Lines changed: 14 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)