Apply suggestion from @jycor

elianddb · jycor · elianddb · commit c9dbaffab676 · 2025-10-09T13:27:45.000-07:00
Co-authored-by: James Cor &lt;jcor@ucsd.edu&gt;
diff --git a/sql/analyzer/optimization_rules.go b/sql/analyzer/optimization_rules.go
@@ -330,7 +330,7 @@ func simplifyFilters(ctx *sql.Context, a *Analyzer, node sql.Node, scope *plan.S
 				if lit, ok := e.Child.(*expression.Literal); ok {
 					val, err := sql.ConvertToBool(ctx, lit.Value())
 					if err != nil {
-						// non-const, keep as is
+						// error while converting, keep as is
 						return e, transform.SameTree, nil
 					}
 					return expression.NewLiteral(!val, e.Type()), transform.NewTree, nil

Original file line number	Diff line number	Diff line change
`@@ -330,7 +330,7 @@ func simplifyFilters(ctx sql.Context, a Analyzer, node sql.Node, scope *plan.S`
`330`	`330`	`if lit, ok := e.Child.(*expression.Literal); ok {`
`331`	`331`	`val, err := sql.ConvertToBool(ctx, lit.Value())`
`332`	`332`	`if err != nil {`
`333`		`- // non-const, keep as is`
	`333`	`+ // error while converting, keep as is`
`334`	`334`	`return e, transform.SameTree, nil`
`335`	`335`	`}`
`336`	`336`	`return expression.NewLiteral(!val, e.Type()), transform.NewTree, nil`