remove TODOs

James Cor · James Cor · commit c9f9abbb41e3 · 2024-10-15T17:02:05.000-07:00
diff --git a/sql/analyzer/apply_foreign_keys.go b/sql/analyzer/apply_foreign_keys.go
@@ -354,7 +354,6 @@ func getForeignKeyRefActions(ctx *sql.Context, a *Analyzer, tbl sql.ForeignKeyTa
 		// If either referential action is not equivalent to RESTRICT, then the updater has the possibility of having
 		// its contents modified, therefore we add it to the chain.
 		if !fk.OnUpdate.IsEquivalentToRestrict() || !fk.OnDelete.IsEquivalentToRestrict() {
-			// TODO: why would I add the updater without the table here?
 			fkChain = fkChain.AddTableUpdater(fk.Database, fk.Table, childUpdater)
 		}
 
@@ -386,7 +385,6 @@ func getForeignKeyRefActions(ctx *sql.Context, a *Analyzer, tbl sql.ForeignKeyTa
 			return nil, err
 		}
 
-		// TODO: does this need to be a deep copy or no???
 		fkChain = fkChain.AddForeignKey(fk.Name)
 		childEditor, err := getForeignKeyEditor(ctx, a, childTbl, cache, fkChain, checkRows)
 		if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -354,7 +354,6 @@ func getForeignKeyRefActions(ctx sql.Context, a Analyzer, tbl sql.ForeignKeyTa`
`354`	`354`	`// If either referential action is not equivalent to RESTRICT, then the updater has the possibility of having`
`355`	`355`	`// its contents modified, therefore we add it to the chain.`
`356`	`356`	`if !fk.OnUpdate.IsEquivalentToRestrict() \|\| !fk.OnDelete.IsEquivalentToRestrict() {`
`357`		`- // TODO: why would I add the updater without the table here?`
`358`	`357`	`fkChain = fkChain.AddTableUpdater(fk.Database, fk.Table, childUpdater)`
`359`	`358`	`}`
`360`	`359`
`@@ -386,7 +385,6 @@ func getForeignKeyRefActions(ctx sql.Context, a Analyzer, tbl sql.ForeignKeyTa`
`386`	`385`	`return nil, err`
`387`	`386`	`}`
`388`	`387`
`389`		`- // TODO: does this need to be a deep copy or no???`
`390`	`388`	`fkChain = fkChain.AddForeignKey(fk.Name)`
`391`	`389`	`childEditor, err := getForeignKeyEditor(ctx, a, childTbl, cache, fkChain, checkRows)`
`392`	`390`	`if err != nil {`