add dialect and mv impl layer

Author: elianddb

enginetest/queries/script_queries.go

@@ -124,7 +124,8 @@ type ScriptTestAssertion struct {
 var ScriptTests = []ScriptTest{
 	{
 		// https://github.com/dolthub/dolt/issues/9935
-		Name: "Incorrect use of negation in AntiJoinIncludingNulls",
+		Dialect: "mysql",
+		Name:    "Incorrect use of negation in AntiJoinIncludingNulls",
 		SetUpScript: []string{
 			"CREATE TABLE t0(c0 INT);",
 			"INSERT INTO t0(c0) VALUES(1);",
@@ -138,6 +139,22 @@ var ScriptTests = []ScriptTest{
 				Query:    "SELECT * FROM t0 WHERE (! (0 || (EXISTS (SELECT 1))));",
 				Expected: []sql.Row{},
 			},
+			{
+				Query:    "SELECT * FROM t0 WHERE (! ((EXISTS (SELECT 1)) || 0));",
+				Expected: []sql.Row{},
+			},
+			{
+				Query:    "SELECT * FROM t0 WHERE (! ((EXISTS (SELECT 1)) || 1));",
+				Expected: []sql.Row{},
+			},
+			{
+				Query:    "SELECT * FROM t0 WHERE (! (1 && (EXISTS (SELECT 1))));",
+				Expected: []sql.Row{},
+			},
+			{
+				Query:    "SELECT * FROM t0 WHERE (! (0 && (EXISTS (SELECT 1))));",
+				Expected: []sql.Row{{1}},
+			},
 			{
 				Query:    "SELECT * FROM t0 WHERE (! (0 || (EXISTS (SELECT 1 FROM t0 WHERE c0 = 2))));",
 				Expected: []sql.Row{{1}},

sql/analyzer/optimization_rules.go

@@ -326,6 +326,16 @@ func simplifyFilters(ctx *sql.Context, a *Analyzer, node sql.Node, scope *plan.S
 				newRightUpper := expression.NewLiteral(valStr, e.RightChild.Type())
 				newExpr := expression.NewAnd(expression.NewGreaterThanOrEqual(e.LeftChild, newRightLower), expression.NewLessThanOrEqual(e.LeftChild, newRightUpper))
 				return newExpr, transform.NewTree, nil
+			case *expression.Not:
+				if lit, ok := e.Child.(*expression.Literal); ok {
+					val, err := sql.ConvertToBool(ctx, lit.Value())
+					if err != nil {
+						// non-const, keep as is
+						return e, transform.SameTree, nil
+					}
+					return expression.NewLiteral(!val, e.Type()), transform.NewTree, nil
+				}
+				return e, transform.SameTree, nil
 			case *expression.Literal, expression.Tuple, *expression.Interval, *expression.CollatedExpression, *expression.MatchAgainst:
 				return e, transform.SameTree, nil
 			default:
@@ -368,28 +378,26 @@ func simplifyFilters(ctx *sql.Context, a *Analyzer, node sql.Node, scope *plan.S
 
 func isFalse(e sql.Expression) bool {
 	lit, ok := e.(*expression.Literal)
-	if ok && lit != nil && lit.Type() == types.Boolean && lit.Value() != nil {
-		switch v := lit.Value().(type) {
-		case bool:
-			return !v
-		case int8:
-			return v == sql.False
-		}
+	if !ok || lit == nil || lit.Value() == nil {
+		return false
 	}
-	return false
+	val, err := sql.ConvertToBool(sql.NewEmptyContext(), lit.Value())
+	if err != nil {
+		return false
+	}
+	return !val
 }
 
 func isTrue(e sql.Expression) bool {
 	lit, ok := e.(*expression.Literal)
-	if ok && lit != nil && lit.Type() == types.Boolean && lit.Value() != nil {
-		switch v := lit.Value().(type) {
-		case bool:
-			return v
-		case int8:
-			return v != sql.False
-		}
+	if !ok || lit == nil || lit.Value() == nil {
+		return false
+	}
+	val, err := sql.ConvertToBool(sql.NewEmptyContext(), lit.Value())
+	if err != nil {
+		return false
 	}
-	return false
+	return val
 }
 
 // pushNotFilters applies De'Morgan's laws to push NOT expressions as low

sql/analyzer/unnest_exists_subqueries.go

@@ -123,19 +123,6 @@ func unnestExistSubqueries(ctx *sql.Context, scope *plan.Scope, a *Analyzer, fil
 		var s *hoistSubquery
 		var err error
 
-		if not, ok := f.(*expression.Not); ok {
-			if lit, ok := not.Child.(*expression.Literal); ok {
-				val, err := sql.ConvertToBool(ctx, lit.Value())
-				if err != nil {
-					// non-const
-				} else if val {
-					return plan.NewEmptyTableWithSchema(ret.Schema()), transform.NewTree, nil
-				} else {
-					continue // always true
-				}
-			}
-		}
-
 		// match subquery expression
 		joinType := plan.JoinTypeSemi
 		var sq *plan.Subquery