Merge pull request #2683 from dolthub/jennifer/parser

use global parser for engine

Author: jennifersp

engine.go

@@ -192,7 +192,7 @@ func New(a *analyzer.Analyzer, cfg *Config) *Engine {
 		PreparedDataCache: NewPreparedDataCache(),
 		mu:                &sync.Mutex{},
 		EventScheduler:    nil,
-		Parser:            sql.NewMysqlParser(),
+		Parser:            sql.GlobalParser,
 	}
 	ret.ReadOnly.Store(cfg.IsReadOnly)
 	return ret

enginetest/queries/check_scripts.go

@@ -293,7 +293,7 @@ CREATE TABLE t4
 		Assertions: []ScriptTestAssertion{
 			{
 				Query:       "ALTER TABLE test ADD CONSTRAINT bad_check CHECK (pk < 5)",
-				ExpectedErr: plan.ErrCheckViolated,
+				ExpectedErr: sql.ErrCheckConstraintViolated,
 			},
 		},
 	},

sql/plan/alter_check.go

@@ -28,9 +28,6 @@ import (
 var (
 	// ErrNoCheckConstraintSupport is returned when the table does not support CONSTRAINT CHECK operations.
 	ErrNoCheckConstraintSupport = errors.NewKind("the table does not support check constraint operations: %s")
-
-	// ErrCheckViolated is returned when the check constraint evaluates to false
-	ErrCheckViolated = errors.NewKind("check constraint %s is violated.")
 )
 
 type CreateCheck struct {

sql/planbuilder/from.go

@@ -826,7 +826,7 @@ func (b *Builder) resolveView(name string, database sql.Database, asOf interface
 				b.ViewCtx().DbName = outerDb
 			}()
 			b.parserOpts = sql.NewSqlModeFromString(viewDef.SqlMode).ParserOptions()
-			stmt, _, _, err := sql.GlobalParser.ParseWithOptions(b.ctx, viewDef.CreateViewStatement, ';', false, b.parserOpts)
+			stmt, _, _, err := b.parser.ParseWithOptions(b.ctx, viewDef.CreateViewStatement, ';', false, b.parserOpts)
 			if err != nil {
 				b.handleErr(err)
 			}

sql/rowexec/ddl_iters.go

@@ -1804,7 +1804,7 @@ func (b *BaseBuilder) executeCreateCheck(ctx *sql.Context, c *plan.CreateCheck)
 		}
 
 		if sql.IsFalse(res) {
-			return plan.ErrCheckViolated.New(c.Check.Name)
+			return sql.ErrCheckConstraintViolated.New(c.Check.Name)
 		}
 	}