comments

James Cor · James Cor · commit d7f4e46d6991 · 2025-10-26T18:11:37.000-07:00
diff --git a/sql/plan/process.go b/sql/plan/process.go
@@ -330,7 +330,7 @@ func (i *TrackedRowIter) NextValueRow(ctx *sql.Context) (sql.ValueRow, error) {
 	return row, nil
 }
 
-// CanSupport implements the sql.ValueRowIter interface.
+// IsValueRowIter implements the sql.ValueRowIter interface.
 func (i *TrackedRowIter) IsValueRowIter(ctx *sql.Context) bool {
 	iter, ok := i.iter.(sql.ValueRowIter)
 	return ok && iter.IsValueRowIter(ctx)
diff --git a/sql/rowexec/transaction_iters.go b/sql/rowexec/transaction_iters.go
@@ -104,7 +104,7 @@ func (t *TransactionCommittingIter) NextValueRow(ctx *sql.Context) (sql.ValueRow
 	return t.childIter.(sql.ValueRowIter).NextValueRow(ctx)
 }
 
-// CanSupport implements the sql.ValueRowIter interface.
+// IsValueRowIter implements the sql.ValueRowIter interface.
 func (t *TransactionCommittingIter) IsValueRowIter(ctx *sql.Context) bool {
 	childIter, ok := t.childIter.(sql.ValueRowIter)
 	return ok && childIter.IsValueRowIter(ctx)

Original file line number	Diff line number	Diff line change
`@@ -330,7 +330,7 @@ func (i TrackedRowIter) NextValueRow(ctx sql.Context) (sql.ValueRow, error) {`
`330`	`330`	`return row, nil`
`331`	`331`	`}`
`332`	`332`
`333`		`-// CanSupport implements the sql.ValueRowIter interface.`
	`333`	`+// IsValueRowIter implements the sql.ValueRowIter interface.`
`334`	`334`	`func (i TrackedRowIter) IsValueRowIter(ctx sql.Context) bool {`
`335`	`335`	`iter, ok := i.iter.(sql.ValueRowIter)`
`336`	`336`	`return ok && iter.IsValueRowIter(ctx)`
Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ func (t TransactionCommittingIter) NextValueRow(ctx sql.Context) (sql.ValueRow`
`104`	`104`	`return t.childIter.(sql.ValueRowIter).NextValueRow(ctx)`
`105`	`105`	`}`
`106`	`106`
`107`		`-// CanSupport implements the sql.ValueRowIter interface.`
	`107`	`+// IsValueRowIter implements the sql.ValueRowIter interface.`
`108`	`108`	`func (t TransactionCommittingIter) IsValueRowIter(ctx sql.Context) bool {`
`109`	`109`	`childIter, ok := t.childIter.(sql.ValueRowIter)`
`110`	`110`	`return ok && childIter.IsValueRowIter(ctx)`