Fix float to bigint conversion result

macneale4 · macneale4 · commit dde1b5fa643f · 2025-05-05T18:07:05.000-07:00
diff --git a/sql/types/number.go b/sql/types/number.go
@@ -969,7 +969,7 @@ func convertToInt64(t NumberTypeImpl_, v interface{}) (int64, sql.ConvertInRange
 		} else if v < float32(math.MinInt64) {
 			return math.MinInt64, sql.OutOfRange, nil
 		}
-		return int64(math.Round(float64(v))), sql.OutOfRange, nil
+		return int64(math.Round(float64(v))), sql.InRange, nil
 	case float64:
 		if v > float64(math.MaxInt64) {
 			return math.MaxInt64, sql.OutOfRange, nil

Original file line number	Diff line number	Diff line change
`@@ -969,7 +969,7 @@ func convertToInt64(t NumberTypeImpl_, v interface{}) (int64, sql.ConvertInRange`
`969`	`969`	`} else if v < float32(math.MinInt64) {`
`970`	`970`	`return math.MinInt64, sql.OutOfRange, nil`
`971`	`971`	`}`
`972`		`- return int64(math.Round(float64(v))), sql.OutOfRange, nil`
	`972`	`+ return int64(math.Round(float64(v))), sql.InRange, nil`
`973`	`973`	`case float64:`
`974`	`974`	`if v > float64(math.MaxInt64) {`
`975`	`975`	`return math.MaxInt64, sql.OutOfRange, nil`