handle decimals, add tests

Author: angelamayxie

enginetest/queries/function_queries.go

@@ -1529,3 +1529,16 @@ var FunctionQueryTests = []QueryTest{
 		},
 	},
 }
+
+// BrokenFunctionQueryTests contains SQL function call queries that don't match MySQL behavior
+var BrokenFunctionQueryTests = []QueryTest{
+	// https://github.com/dolthub/dolt/issues/9735
+	{
+		Query:    "select log('10asdf', '100f')",
+		Expected: []sql.Row{{float64(2)}},
+	},
+	{
+		Query:    "select log('a10asdf', 'b100f')",
+		Expected: []sql.Row{{nil}},
+	},
+}

enginetest/queries/script_queries.go

@@ -11439,6 +11439,134 @@ select * from t1 except (
 			},
 		},
 	},
+	{
+		// https://github.com/dolthub/go-mysql-server/pull/3176
+		Name: "strings cast to numbers",
+		SetUpScript: []string{
+			"create table test01(pk varchar(20) primary key)",
+			`insert into test01 values ('  3 12 4'),
+                          ('  3.2 12 4'),('-3.1234'),('-3.1a'),('-5+8'),('+3.1234'),
+                          ('11d'),('11wha?'),('11'),('12'),('1a1'),('a1a1'),('11-5'),
+                          ('3. 12 4'),('5.932887e+07'),('5.932887e+07abc'),('5.932887e7'),('5.932887e7abc')`,
+		},
+		Assertions: []ScriptTestAssertion{
+			{
+				Query: "select pk, cast(pk as float) from test01",
+				Expected: []sql.Row{
+					{"  3 12 4", float32(3)},
+					{"  3.2 12 4", float32(3.2)},
+					{"-3.1234", float32(-3.1234)},
+					{"-3.1a", float32(-3.1)},
+					{"-5+8", float32(-5)},
+					{"+3.1234", float32(3.1234)},
+					{"11", float32(11)},
+					{"11-5", float32(11)},
+					{"11d", float32(11)},
+					{"11wha?", float32(11)},
+					{"12", float32(12)},
+					{"1a1", float32(1)},
+					{"3. 12 4", float32(3)},
+					{"5.932887e+07", float32(5.932887e+07)},
+					{"5.932887e+07abc", float32(5.932887e+07)},
+					{"5.932887e7", float32(5.932887e+07)},
+					{"5.932887e7abc", float32(5.932887e+07)},
+					{"a1a1", float32(0)},
+				},
+			},
+			{
+				Query: "select pk, cast(pk as double) from test01",
+				Expected: []sql.Row{
+					{"  3 12 4", 3.0},
+					{"  3.2 12 4", 3.2},
+					{"-3.1234", -3.1234},
+					{"-3.1a", -3.1},
+					{"-5+8", -5.0},
+					{"+3.1234", 3.1234},
+					{"11", 11.0},
+					{"11-5", 11.0},
+					{"11d", 11.0},
+					{"11wha?", 11.0},
+					{"12", 12.0},
+					{"1a1", 1.0},
+					{"3. 12 4", 3.0},
+					{"5.932887e+07", 5.932887e+07},
+					{"5.932887e+07abc", 5.932887e+07},
+					{"5.932887e7", 5.932887e+07},
+					{"5.932887e7abc", 5.932887e+07},
+					{"a1a1", 0.0},
+				},
+			},
+			{
+				Query: "select pk, cast(pk as signed) from test01",
+				Expected: []sql.Row{
+					{"  3 12 4", 3},
+					{"  3.2 12 4", 3},
+					{"-3.1234", -3},
+					{"-3.1a", -3},
+					{"-5+8", -5},
+					{"+3.1234", 3},
+					{"11", 11},
+					{"11-5", 11},
+					{"11d", 11},
+					{"11wha?", 11},
+					{"12", 12},
+					{"1a1", 1},
+					{"3. 12 4", 3},
+					{"5.932887e+07", 5},
+					{"5.932887e+07abc", 5},
+					{"5.932887e7", 5},
+					{"5.932887e7abc", 5},
+					{"a1a1", 0},
+				},
+			},
+			{
+				Query: "select pk, cast(pk as unsigned) from test01",
+				Expected: []sql.Row{
+					{"  3 12 4", uint64(3)},
+					{"  3.2 12 4", uint64(3)},
+					{"-3.1234", uint64(18446744073709551613)},
+					{"-3.1a", uint64(18446744073709551613)},
+					{"-5+8", uint64(18446744073709551611)},
+					{"+3.1234", uint64(3)},
+					{"11", uint64(11)},
+					{"11-5", uint64(11)},
+					{"11d", uint64(11)},
+					{"11wha?", uint64(11)},
+					{"12", uint64(12)},
+					{"1a1", uint64(1)},
+					{"3. 12 4", uint64(3)},
+					{"5.932887e+07", uint64(5)},
+					{"5.932887e+07abc", uint64(5)},
+					{"5.932887e7", uint64(5)},
+					{"5.932887e7abc", uint64(5)},
+					{"a1a1", uint64(0)},
+				},
+			},
+			{
+				Query: "select pk, cast(pk as decimal(12,3)) from test01",
+				Expected: []sql.Row{
+					{"  3 12 4", "3.000"},
+					{"  3.2 12 4", "3.200"},
+					{"-3.1234", "-3.123"},
+					{"-3.1a", "-3.100"},
+					{"-5+8", "-5.000"},
+					{"+3.1234", "3.123"},
+					{"11", "11.000"},
+					{"11-5", "11.000"},
+					{"11d", "11.000"},
+					{"11wha?", "11.000"},
+					{"12", "12.000"},
+					{"1a1", "1.000"},
+					{"3. 12 4", "3.000"},
+					{"5.932887e+07", "59328870.000"},
+					{"5.932887e+07abc", "59328870.000"},
+					{"5.932887e7", "59328870.000"},
+					{"5.932887e7abc", "59328870.000"},
+					{"a1a1", "0.000"},
+				},
+			},
+		},
+	},
 }
 
 var SpatialScriptTests = []ScriptTest{

sql/expression/convert.go

@@ -343,7 +343,7 @@ func convertValue(ctx *sql.Context, val interface{}, castTo string, originType s
 		}
 		return d, nil
 	case ConvertToDecimal:
-		value, err := convertHexBlobToDecimalForNumericContext(val, originType)
+		value, err := prepareForNumericContext(val, originType, false)
 		if err != nil {
 			return nil, err
 		}