dolthub/dolt#9481 - Fix auto_increment validation and test expectations

- Use existing types.Is*() functions instead of vitess constants
- Fix blob test expectations (column names were incorrect)
- Comprehensive validation matches MySQL behavior exactly
- All 22 data types tested: 8 valid, 14 invalid with proper errors

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: elianddb

enginetest/queries/script_queries.go

@@ -8219,15 +8219,15 @@ where
 			},
 			{
 				Query:          "create table bad (tb tinyblob primary key auto_increment);",
-				ExpectedErrStr: "Incorrect column specifier for column 'b'",
+				ExpectedErrStr: "Incorrect column specifier for column 'tb'",
 			},
 			{
 				Query:          "create table bad (mb mediumblob primary key auto_increment);",
-				ExpectedErrStr: "Incorrect column specifier for column 'b'",
+				ExpectedErrStr: "Incorrect column specifier for column 'mb'",
 			},
 			{
 				Query:          "create table bad (lb longblob primary key auto_increment);",
-				ExpectedErrStr: "Incorrect column specifier for column 'b'",
+				ExpectedErrStr: "Incorrect column specifier for column 'lb'",
 			},
 		},
 	},

sql/analyzer/validate_create_table.go

@@ -17,8 +17,6 @@ package analyzer
 import (
 	"strings"
 
-	"github.com/dolthub/vitess/go/vt/proto/query"
-
 	"github.com/dolthub/go-mysql-server/sql"
 	"github.com/dolthub/go-mysql-server/sql/expression"
 	"github.com/dolthub/go-mysql-server/sql/plan"
@@ -792,44 +790,32 @@ func removeInSchema(sch sql.Schema, colName, tableName string) sql.Schema {
 
 // validateAutoIncrementType returns true if the given type can be used with AUTO_INCREMENT
 func validateAutoIncrementType(t sql.Type) bool {
-	if t == nil {
+	// Check for invalid types first
+	if types.IsEnum(t) || types.IsSet(t) || types.IsBit(t) {
 		return false
 	}
-
-	switch t.Type() {
-	// Integer types - allowed
-	case query.Type_INT8, query.Type_UINT8, query.Type_INT16, query.Type_UINT16,
-		query.Type_INT24, query.Type_UINT24, query.Type_INT32, query.Type_UINT32,
-		query.Type_INT64, query.Type_UINT64:
-		return true
-
-	// Floating point types - allowed
-	case query.Type_FLOAT32, query.Type_FLOAT64:
-		return true
-
-	// Text/string types - not allowed
-	case query.Type_CHAR, query.Type_VARCHAR, query.Type_TEXT,
-		query.Type_BLOB, query.Type_BINARY, query.Type_VARBINARY:
-		return false
-
-	// Decimal - not allowed per MySQL behavior
-	case query.Type_DECIMAL:
-		return false
-
-	// Date/time types - not allowed
-	case query.Type_DATE, query.Type_TIME, query.Type_DATETIME,
-		query.Type_TIMESTAMP, query.Type_YEAR:
+	
+	// Check for text/string types - not allowed (includes TEXT, VARCHAR, CHAR, BLOB, BINARY, etc.)
+	if types.IsText(t) {
 		return false
-
-	// Other types - not allowed
-	case query.Type_ENUM, query.Type_SET, query.Type_BIT,
-		query.Type_JSON, query.Type_GEOMETRY:
-		return false
-
-	// Default to false for any other types
-	default:
+	}
+	
+	// Check for datetime/time types - not allowed
+	if types.IsTime(t) || types.IsDateType(t) || types.IsDatetimeType(t) || types.IsTimestampType(t) || types.IsYear(t) {
 		return false
 	}
+	
+	// Check for numeric types - only these are potentially allowed
+	if types.IsNumber(t) {
+		// DECIMAL is not allowed for auto_increment per MySQL behavior
+		if types.IsDecimal(t) {
+			return false
+		}
+		return true
+	}
+	
+	// Default to false for any other types (JSON, Geometry, etc.)
+	return false
 }
 
 func validateAutoIncrementModify(schema sql.Schema, keyedColumns map[string]bool) error {