add fix for const evals

Author: elianddb

enginetest/queries/script_queries.go

@@ -122,6 +122,36 @@ type ScriptTestAssertion struct {
 // Unlike other engine tests, ScriptTests must be self-contained. No other tables are created outside the definition of
 // the tests.
 var ScriptTests = []ScriptTest{
+	{
+		// https://github.com/dolthub/dolt/issues/9935
+		Name: "Incorrect use of negation in AntiJoinIncludingNulls",
+		SetUpScript: []string{
+			"CREATE TABLE t0(c0 INT);",
+			"INSERT INTO t0(c0) VALUES(1);",
+		},
+		Assertions: []ScriptTestAssertion{
+			{
+				Query:    "SELECT * FROM t0 WHERE (! (1 || (EXISTS (SELECT 1))));",
+				Expected: []sql.Row{},
+			},
+			{
+				Query:    "SELECT * FROM t0 WHERE (! (0 || (EXISTS (SELECT 1))));",
+				Expected: []sql.Row{},
+			},
+			{
+				Query:    "SELECT * FROM t0 WHERE (! (0 || (EXISTS (SELECT 1 FROM t0 WHERE c0 = 2))));",
+				Expected: []sql.Row{{1}},
+			},
+			{
+				Query:    "SELECT * FROM t0 WHERE (! (1 || (EXISTS (SELECT 1 FROM t0 WHERE c0 = 1))));",
+				Expected: []sql.Row{},
+			},
+			{
+				Query:    "SELECT * FROM t0 WHERE (! (0 || (EXISTS (SELECT 1 FROM t0 WHERE c0 = 1))));",
+				Expected: []sql.Row{},
+			},
+		},
+	}
 	{
 		// https://github.com/dolthub/dolt/issues/9865
 		Name:    "Stored procedure containing a transaction does not return EOF",

sql/analyzer/unnest_exists_subqueries.go

@@ -123,6 +123,19 @@ func unnestExistSubqueries(ctx *sql.Context, scope *plan.Scope, a *Analyzer, fil
 		var s *hoistSubquery
 		var err error
 
+		if not, ok := f.(*expression.Not); ok {
+			if lit, ok := not.Child.(*expression.Literal); ok {
+				val, err := sql.ConvertToBool(ctx, lit.Value())
+				if err != nil {
+					// non-const
+				} else if val {
+					return plan.NewEmptyTableWithSchema(ret.Schema()), transform.NewTree, nil
+				} else {
+					continue // always true
+				}
+			}
+		}
+
 		// match subquery expression
 		joinType := plan.JoinTypeSemi
 		var sq *plan.Subquery