dolthub/dolt#9481 - Move auto_increment validation to GMS

Move auto_increment constraint validation entirely from Dolt to
go-mysql-server for better separation of concerns and MySQL compatibility.

Changes:
- Add validateAutoIncrementType() function using existing type checking
- Fix validation order to prioritize auto_increment before index validation
- Unskip comprehensive test coverage for all invalid data types
- Fix bugs: YEAR and BIT types were incorrectly allowed
- Ensure exact MySQL error message compatibility

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: elianddb

enginetest/queries/script_queries.go

@@ -8157,7 +8157,6 @@ where
 
 	// Char tests
 	{
-		Skip:        true,
 		Name:        "char with auto_increment",
 		Dialect:     "mysql",
 		SetUpScript: []string{},
@@ -8171,7 +8170,6 @@ where
 
 	// Varchar tests
 	{
-		Skip:        true,
 		Name:        "varchar with auto_increment",
 		Dialect:     "mysql",
 		SetUpScript: []string{},
@@ -8185,7 +8183,6 @@ where
 
 	// Binary tests
 	{
-		Skip:        true,
 		Name:        "binary with auto_increment",
 		Dialect:     "mysql",
 		SetUpScript: []string{},
@@ -8199,7 +8196,6 @@ where
 
 	// Varbinary tests
 	{
-		Skip:        true,
 		Name:        "varbinary with auto_increment",
 		Dialect:     "mysql",
 		SetUpScript: []string{},
@@ -8213,7 +8209,6 @@ where
 
 	// Blob tests
 	{
-		Skip:        true,
 		Name:        "blob with auto_increment",
 		Dialect:     "mysql",
 		SetUpScript: []string{},
@@ -8239,7 +8234,6 @@ where
 
 	// Text Tests
 	{
-		Skip:        true,
 		Name:        "text with auto_increment",
 		Dialect:     "mysql",
 		SetUpScript: []string{},
@@ -9969,7 +9963,6 @@ where
 
 	// Bit Tests
 	{
-		Skip:        true,
 		Name:        "bit with auto_increment",
 		Dialect:     "mysql",
 		SetUpScript: []string{},
@@ -10095,7 +10088,6 @@ where
 
 	// Decimal Tests
 	{
-		Skip:        true,
 		Name:        "decimal with auto_increment",
 		Dialect:     "mysql",
 		SetUpScript: []string{},
@@ -10113,7 +10105,6 @@ where
 
 	// Date Tests
 	{
-		Skip:        true,
 		Name:        "date with auto_increment",
 		Dialect:     "mysql",
 		SetUpScript: []string{},
@@ -10127,7 +10118,6 @@ where
 
 	// Datetime Tests
 	{
-		Skip:        true,
 		Name:        "datetime with auto_increment",
 		Dialect:     "mysql",
 		SetUpScript: []string{},
@@ -10145,7 +10135,6 @@ where
 
 	// Timestamp Tests
 	{
-		Skip:        true,
 		Name:        "timestamp with auto_increment",
 		Dialect:     "mysql",
 		SetUpScript: []string{},
@@ -10163,7 +10152,6 @@ where
 
 	// Time Tests
 	{
-		Skip:        true,
 		Name:        "time with auto_increment",
 		Dialect:     "mysql",
 		SetUpScript: []string{},
@@ -10181,7 +10169,6 @@ where
 
 	// Year Tests
 	{
-		Skip:        true,
 		Name:        "year with auto_increment",
 		Dialect:     "mysql",
 		SetUpScript: []string{},

sql/analyzer/validate_create_table.go

@@ -40,30 +40,31 @@ func validateCreateTable(ctx *sql.Context, a *Analyzer, n sql.Node, scope *plan.
 
 	sch := ct.PkSchema().Schema
 	idxs := ct.Indexes()
-	strictMySQLCompat, err := isStrictMysqlCompatibilityEnabled(ctx)
-	if err != nil {
-		return nil, transform.SameTree, err
+
+	// First validate auto_increment columns before other validations
+	// This ensures proper error precedence matching MySQL behavior
+	keyedColumns := make(map[string]bool)
+	for _, index := range idxs {
+		for _, col := range index.Columns {
+			keyedColumns[col.Name] = true
+		}
 	}
-	err = validateIndexes(ctx, sch, idxs, strictMySQLCompat)
+
+	err = validateAutoIncrementModify(sch, keyedColumns)
 	if err != nil {
 		return nil, transform.SameTree, err
 	}
 
-	err = validateNoVirtualColumnsInPrimaryKey(sch)
+	strictMySQLCompat, err := isStrictMysqlCompatibilityEnabled(ctx)
 	if err != nil {
 		return nil, transform.SameTree, err
 	}
-
-	// passed validateIndexes, so they all must be valid indexes
-	// extract map of columns that have indexes defined over them
-	keyedColumns := make(map[string]bool)
-	for _, index := range idxs {
-		for _, col := range index.Columns {
-			keyedColumns[col.Name] = true
-		}
+	err = validateIndexes(ctx, sch, idxs, strictMySQLCompat)
+	if err != nil {
+		return nil, transform.SameTree, err
 	}
 
-	err = validateAutoIncrementModify(sch, keyedColumns)
+	err = validateNoVirtualColumnsInPrimaryKey(sch)
 	if err != nil {
 		return nil, transform.SameTree, err
 	}
@@ -787,12 +788,42 @@ func removeInSchema(sch sql.Schema, colName, tableName string) sql.Schema {
 	return schCopy
 }
 
+// validateAutoIncrementType returns true if the given type can be used with AUTO_INCREMENT
+func validateAutoIncrementType(t sql.Type) bool {
+	// Check for invalid types first
+	if types.IsEnum(t) || types.IsSet(t) || types.IsBit(t) {
+		return false
+	}
+	
+	// Check for text/string types - not allowed (includes TEXT, VARCHAR, CHAR, BLOB, BINARY, etc.)
+	if types.IsText(t) {
+		return false
+	}
+	
+	// Check for datetime/time types - not allowed
+	if types.IsTime(t) || types.IsDateType(t) || types.IsDatetimeType(t) || types.IsTimestampType(t) || types.IsYear(t) {
+		return false
+	}
+	
+	// Check for numeric types - only these are potentially allowed
+	if types.IsNumber(t) {
+		// DECIMAL is not allowed for auto_increment per MySQL behavior
+		if types.IsDecimal(t) {
+			return false
+		}
+		return true
+	}
+	
+	// Default to false for any other types (JSON, Geometry, etc.)
+	return false
+}
+
 func validateAutoIncrementModify(schema sql.Schema, keyedColumns map[string]bool) error {
 	seen := false
 	for _, col := range schema {
 		if col.AutoIncrement {
 			// Check if column type is valid for auto_increment
-			if types.IsEnum(col.Type) {
+			if !validateAutoIncrementType(col.Type) {
 				return sql.ErrInvalidColumnSpecifier.New(col.Name)
 			}
 			// keyedColumns == nil means they are trying to add auto_increment column
@@ -820,7 +851,7 @@ func validateAutoIncrementAdd(schema sql.Schema, keyColumns map[string]bool) err
 		if col.AutoIncrement {
 			{
 				// Check if column type is valid for auto_increment
-				if types.IsEnum(col.Type) {
+				if !validateAutoIncrementType(col.Type) {
 					return sql.ErrInvalidColumnSpecifier.New(col.Name)
 				}
 				if !col.PrimaryKey && !keyColumns[col.Name] {