Merge pull request #1859 from testwill/copy

chore: use copy(to, from) instead of a loop

Author: fulghum

memory/table_editor.go

@@ -288,12 +288,8 @@ func (t *tableEditor) IndexedAccess(i sql.IndexLookup) sql.IndexedTable {
 		}
 		adds := make([]sql.Row, len(nonPkTea.adds))
 		deletes := make([]sql.Row, len(nonPkTea.deletes))
-		for i, val := range nonPkTea.adds {
-			adds[i] = val
-		}
-		for i, val := range nonPkTea.deletes {
-			deletes[i] = val
-		}
+		copy(adds, nonPkTea.adds)
+		copy(deletes, nonPkTea.deletes)
 		err = (&keylessTableEditAccumulator{
 			table:   newTable,
 			adds:    adds,

sql/plan/ddl.go

@@ -649,9 +649,7 @@ func (d *DropTable) WithChildren(children ...sql.Node) (sql.Node, error) {
 	// Number of children can be smaller than original as the non-existent
 	// tables get filtered out in some cases
 	var newChildren = make([]sql.Node, len(children))
-	for i, child := range children {
-		newChildren[i] = child
-	}
+	copy(newChildren, children)
 	nd := *d
 	nd.Tables = newChildren
 	return &nd, nil

sql/range.go

@@ -123,9 +123,7 @@ func (rang Range) IsEmpty() (bool, error) {
 // Copy returns a duplicate of this Range.
 func (rang Range) Copy() Range {
 	newRange := make(Range, len(rang))
-	for i, colExpr := range rang {
-		newRange[i] = colExpr // RangeColumnExpr and all of its members are non-pointer types, so they're copied
-	}
+	copy(newRange, rang)
 	return newRange
 }
 

sql/rowexec/insert.go

@@ -152,9 +152,7 @@ func (i *insertIter) Next(ctx *sql.Context) (returnRow sql.Row, returnErr error)
 					return nil, sql.NewWrappedInsertError(row, err)
 				}
 				// the row had to be deleted, write the values into the toReturn row
-				for i := 0; i < len(ue.Existing); i++ {
-					toReturn[i] = ue.Existing[i]
-				}
+				copy(toReturn, ue.Existing)
 			} else {
 				break
 			}

sql/rowexec/rel.go

@@ -525,9 +525,7 @@ func (b *BaseBuilder) buildInto(ctx *sql.Context, n *plan.Into, row sql.Row) (sq
 
 	var rowValues = make([]interface{}, len(rows[0]))
 
-	for j, val := range rows[0] {
-		rowValues[j] = val
-	}
+	copy(rowValues, rows[0])
 
 	for j, v := range n.IntoVars {
 		switch variable := v.(type) {

sql/rows.go

@@ -42,9 +42,7 @@ func (r Row) Copy() Row {
 // Append appends all the values in r2 to this row and returns the result
 func (r Row) Append(r2 Row) Row {
 	row := make(Row, len(r)+len(r2))
-	for i := range r {
-		row[i] = r[i]
-	}
+	copy(row, r)
 	for i := range r2 {
 		row[i+len(r)] = r2[i]
 	}