Passing context through

Author: fulghum

sql/analyzer/validate_create_table.go

@@ -397,7 +397,7 @@ func validateAlterIndex(ctx *sql.Context, initialSch, sch sql.Schema, ai *plan.A
 		if !ok {
 			return nil, sql.ErrKeyColumnDoesNotExist.New(badColName)
 		}
-		err := validateIndexType(ai.Columns, sch)
+		err := validateIndexType(ctx, ai.Columns, sch)
 		if err != nil {
 			return nil, err
 		}
@@ -455,7 +455,7 @@ func validateAlterIndex(ctx *sql.Context, initialSch, sch sql.Schema, ai *plan.A
 }
 
 // validatePrefixLength handles all errors related to creating indexes with prefix lengths
-func validatePrefixLength(schCol *sql.Column, idxCol sql.IndexColumn) error {
+func validatePrefixLength(ctx *sql.Context, schCol *sql.Column, idxCol sql.IndexColumn) error {
 	// Throw prefix length error for non-string types with prefixes
 	if idxCol.Length > 0 && !types.IsText(schCol.Type) {
 		return sql.ErrInvalidIndexPrefix.New(schCol.Name)
@@ -473,7 +473,7 @@ func validatePrefixLength(schCol *sql.Column, idxCol sql.IndexColumn) error {
 	}
 
 	// The specified prefix length is longer than the column
-	maxByteLength := int64(schCol.Type.MaxTextResponseByteLength())
+	maxByteLength := int64(schCol.Type.MaxTextResponseByteLength(ctx))
 	if prefixByteLength > maxByteLength {
 		return sql.ErrInvalidIndexPrefix.New(schCol.Name)
 	}
@@ -487,10 +487,10 @@ func validatePrefixLength(schCol *sql.Column, idxCol sql.IndexColumn) error {
 }
 
 // validateIndexType prevents creating invalid indexes
-func validateIndexType(cols []sql.IndexColumn, sch sql.Schema) error {
+func validateIndexType(ctx *sql.Context, cols []sql.IndexColumn, sch sql.Schema) error {
 	for _, idxCol := range cols {
 		schCol := sch[sch.IndexOfColName(idxCol.Name)]
-		err := validatePrefixLength(schCol, idxCol)
+		err := validatePrefixLength(ctx, schCol, idxCol)
 		if err != nil {
 			return err
 		}

sql/information_schema/columns_table.go

@@ -209,7 +209,7 @@ func getRowFromColumn(ctx *sql.Context, curOrdPos int, col *sql.Column, dbName,
 		}
 	}
 
-	charName, collName, charMaxLen, charOctetLen := getCharAndCollNamesAndCharMaxAndOctetLens(col.Type)
+	charName, collName, charMaxLen, charOctetLen := getCharAndCollNamesAndCharMaxAndOctetLens(ctx, col.Type)
 
 	numericPrecision, numericScale := getColumnPrecisionAndScale(col.Type)
 	if types.IsDatetimeType(col.Type) || types.IsTimestampType(col.Type) {
@@ -539,7 +539,7 @@ func getColumnPrecisionAndScale(colType sql.Type) (interface{}, interface{}) {
 	}
 }
 
-func getCharAndCollNamesAndCharMaxAndOctetLens(colType sql.Type) (interface{}, interface{}, interface{}, interface{}) {
+func getCharAndCollNamesAndCharMaxAndOctetLens(ctx *sql.Context, colType sql.Type) (interface{}, interface{}, interface{}, interface{}) {
 	var (
 		charName     interface{}
 		collName     interface{}
@@ -551,8 +551,8 @@ func getCharAndCollNamesAndCharMaxAndOctetLens(colType sql.Type) (interface{}, i
 		collName = colColl.Name()
 		charName = colColl.CharacterSet().String()
 		if types.IsEnum(colType) || types.IsSet(colType) {
-			charOctetLen = int64(colType.MaxTextResponseByteLength())
-			charMaxLen = int64(colType.MaxTextResponseByteLength()) / colColl.CharacterSet().MaxLength()
+			charOctetLen = int64(colType.MaxTextResponseByteLength(ctx))
+			charMaxLen = int64(colType.MaxTextResponseByteLength(ctx)) / colColl.CharacterSet().MaxLength()
 		}
 	}
 	if st, ok := colType.(sql.StringType); ok {

sql/information_schema/routines_table.go

@@ -285,7 +285,7 @@ func parametersRowIter(ctx *Context, c Catalog, p map[string][]*plan.Procedure)
 					parameterMode = "OUT"
 				}
 
-				charName, collName, charMaxLen, charOctetLen := getCharAndCollNamesAndCharMaxAndOctetLens(param.Type)
+				charName, collName, charMaxLen, charOctetLen := getCharAndCollNamesAndCharMaxAndOctetLens(ctx, param.Type)
 				numericPrecision, numericScale := getColumnPrecisionAndScale(param.Type)
 				// float types get nil for numericScale, but it gets 0 for this table
 				if _, ok := param.Type.(NumberType); ok {

sql/types/set.go

@@ -66,7 +66,7 @@ func CreateSetType(values []string, collation sql.CollationID) (sql.SetType, err
 	var maxByteLength uint32
 	maxCharLength := collation.Collation().CharacterSet.MaxLength()
 	for i, value := range values {
-		// ...SET member values should not themselves contain commas.
+		// SET member values should not themselves contain commas.
 		if strings.Contains(value, ",") {
 			return nil, fmt.Errorf("values cannot contain a comma")
 		}