Disable the short circuiting of comparing wrapped values until we confirm it has a real performance benefit, and not a performance penalty.

Author: nicktobey

memory/wrapper_test.go

@@ -176,6 +176,7 @@ func TestWrapperCompare(t *testing.T) {
 
 // TestWrapperCompare tests that a wrapped value can be used in comparisons without being unwrapped.
 func TestWrapperSelfCompare(t *testing.T) {
+	t.Skip("This is not currently enabled because it may have performance implications.")
 	db := memory.NewDatabase("db")
 	pro := memory.NewDBProvider(db)
 	ctx := newContext(pro)

sql/expression/comparison.go

@@ -127,26 +127,6 @@ func (c *comparison) Compare(ctx *sql.Context, row sql.Row) (int, error) {
 		return 0, ErrNilOperand.New()
 	}
 
-	if wrapperLeft, isWrapperLeft := left.(sql.AnyWrapper); isWrapperLeft {
-		cmp, isComparable, err := wrapperLeft.Compare(ctx, right)
-		if err != nil {
-			return 0, err
-		}
-		if isComparable {
-			return cmp, nil
-		}
-	}
-
-	if wrapperRight, isWrapperRight := right.(sql.AnyWrapper); isWrapperRight {
-		cmp, isComparable, err := wrapperRight.Compare(ctx, left)
-		if err != nil {
-			return 0, err
-		}
-		if isComparable {
-			return -cmp, nil
-		}
-	}
-
 	left, err = sql.UnwrapAny(ctx, left)
 	if err != nil {
 		return 0, err