Skip to content

Commit fbc08af

Browse files
committed
updated TODOs
1 parent 3583a81 commit fbc08af

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

enginetest/queries/script_queries.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11835,7 +11835,7 @@ select * from t1 except (
1183511835
{"a1a1", uint64(0)},
1183611836
},
1183711837
// TODO: Should be 19. Missing warnings for "Cast to unsigned converted negative integer to its positive
11838-
// complement" (1105)
11838+
// complement" (1105) https://github.com/dolthub/dolt/issues/9840
1183911839
ExpectedWarningsCount: 16,
1184011840
ExpectedWarning: mysql.ERTruncatedWrongValue,
1184111841
},

sql/core.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -362,6 +362,7 @@ func TrimStringToNumberPrefix(ctx *Context, s string, isInt bool) string {
362362
seenExp = true
363363
signIndex = i + 1
364364
} else if !((char == '-' || char == '+') && i == signIndex) {
365+
// TODO add different warning for DECIMAL conversion
365366
if isInt {
366367
ctx.Warn(mysql.ERTruncatedWrongValue, "Truncated incorrect INTEGER value: '%s'", s)
367368
} else {

0 commit comments

Comments
 (0)