compare and convert system types properly #2700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
approved these changes
Oct 15, 2024
Contributor
max-hoffman
left a comment
max-hoffman
left a comment
There was a problem hiding this comment.
LGTM. The extension to this might be adding tests for other functions, presumably we don't test system types in many other places.
Contributor
Author
|
regression test fix here: dolthub/doltgresql#856 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
IsType()methods now account for system variable types,create table from select ...statements account for system variable typesNote: MySQL lists
@@admin_portas Integer in their docs, but shows up asUIntegerin the CLIfixes: dolthub/dolt#8448